-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with Buttons in sistent #5705
Conversation
Signed-off-by: mannika763 <[email protected]>
🚀 Preview for commit 5ce6086 at: https://669c1405710cf52bef257bf2--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mannika763!
Ideally, this navigation is dynamically driven... @sudhanshutech, @vishalvivekm
@mannika763 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
@mannika763 requirements are updated now. Kindly check it. |
@mannika763 Are you going to work on the issue with updates within this PR? so I assigned that task (issue) to you. |
@Muhammed-Moinuddin |
Signed-off-by: mannika763 <[email protected]>
Hey @Muhammed-Moinuddin |
🚀 Preview for commit 4e2dc76 at: https://66a1fcd665ce06c820dcbb91--layer5.netlify.app |
Kindly try to follow css of those buttons for font-size, font-weight, button padding. |
Signed-off-by: mannika763 <[email protected]>
Hey @Muhammed-Moinuddin |
🚀 Preview for commit 48881ab at: https://66a3b3aedc39401c7ed57d18--layer5.netlify.app |
@Muhammed-Moinuddin, I wonder if you have additional feedback. |
You didn't got my point. I've mentioned opacity for just those (Next and Previous) texts. In below image I've used 0.9 opacity for those texts (Next and Previous). You have also not followed font-weight from that docs site. The padding is also not right.
Will you be able to join Monday meeting (Layer5 website discussion meeting)?. I can explain in detail over there. |
Could you please share the link to the documentation for padding and font size? I'm having a hard time finding it. |
This can help you: https://layer5.io/projects/sistent/components/button |
okay @Muhammed-Moinuddin |
@mannika763.. Yes, you're right about the meeting. The Slack huddle is a feature for video call or voice meeting within Slack for quick discussions... |
Signed-off-by: mannika763 <[email protected]>
Hi @Muhammed-Moinuddin |
🚀 Preview for commit 7fc22a3 at: https://66aa5948d596281322069d7d--layer5.netlify.app |
@mannika763, Failing!! |
closing pr since its abandoned |
Description
This PR fixes #5695
Notes for Reviewers
Signed commits