Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Buttons in sistent #5705

Closed
wants to merge 4 commits into from

Conversation

mannika763
Copy link
Contributor

@mannika763 mannika763 commented Jul 20, 2024

Description

This PR fixes #5695

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 20, 2024

🚀 Preview for commit 5ce6086 at: https://669c1405710cf52bef257bf2--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mannika763!

Ideally, this navigation is dynamically driven... @sudhanshutech, @vishalvivekm

@leecalcote leecalcote added the area/projects An issue relating to Layer5 initiatives (projects) label Jul 20, 2024
@Ashparshp
Copy link
Contributor

@mannika763 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@Muhammed-Moinuddin
Copy link
Contributor

@mannika763 requirements are updated now. Kindly check it.

@Muhammed-Moinuddin
Copy link
Contributor

@mannika763 Are you going to work on the issue with updates within this PR? so I assigned that task (issue) to you.
Otherwise I will close this PR and will assign it to someone else. Kindly let me know.

@mannika763
Copy link
Contributor Author

@Muhammed-Moinuddin
Thank you for asking.
I am working on it. will give you an update shortly

@mannika763
Copy link
Contributor Author

Hey @Muhammed-Moinuddin
I have updated the code but I am not sure about the styling of the buttons. Please let me know if there are any necessary changes.

@l5io
Copy link
Contributor

l5io commented Jul 25, 2024

🚀 Preview for commit 4e2dc76 at: https://66a1fcd665ce06c820dcbb91--layer5.netlify.app

@Muhammed-Moinuddin
Copy link
Contributor

Hey @Muhammed-Moinuddin I have updated the code but I am not sure about the styling of the buttons. Please let me know if there are any necessary changes.

Kindly try to follow css of those buttons for font-size, font-weight, button padding.
Add a bit space between both texts (like inbetween Next and Text-Input -> ). I think opacity of 0.8 will make Next and Previous texts more suitable.
Please use icons as well (like we have done on those docs).

Signed-off-by: mannika763 <[email protected]>
@mannika763
Copy link
Contributor Author

Hey @Muhammed-Moinuddin
I have made some CSS changes. Please let me know what works for you and what doesn't. Additionally, here's how the buttons will look with an opacity of 0.8.
image

@l5io
Copy link
Contributor

l5io commented Jul 26, 2024

🚀 Preview for commit 48881ab at: https://66a3b3aedc39401c7ed57d18--layer5.netlify.app

@leecalcote
Copy link
Member

@Muhammed-Moinuddin, I wonder if you have additional feedback.

@Muhammed-Moinuddin
Copy link
Contributor

Muhammed-Moinuddin commented Jul 26, 2024

Hey @Muhammed-Moinuddin I have made some CSS changes. Please let me know what works for you and what doesn't. Additionally, here's how the buttons will look with an opacity of 0.8. image

You didn't got my point. I've mentioned opacity for just those (Next and Previous) texts. In below image I've used 0.9 opacity for those texts (Next and Previous). You have also not followed font-weight from that docs site. The padding is also not right.
In the live preview link the icons do not have proper color.

Screenshot from 2024-07-27 03-26-41
I was looking for above kind of buttons (ignore those arrows).

Will you be able to join Monday meeting (Layer5 website discussion meeting)?. I can explain in detail over there.
Calender link: https://layer5.io/community/calendar

@mannika763
Copy link
Contributor Author

Could you please share the link to the documentation for padding and font size? I'm having a hard time finding it.

@Muhammed-Moinuddin
Copy link
Contributor

Muhammed-Moinuddin commented Jul 31, 2024

Could you please share the link to the documentation for padding and font size? I'm having a hard time finding it.

This can help you: https://layer5.io/projects/sistent/components/button
You can simply follow font-size and padding from those docs button, what is your confusion?.You should join Website meeting for detailed discussion.
Optimally I can explain via slack huddle.

@mannika763
Copy link
Contributor Author

okay @Muhammed-Moinuddin
Just to clarify, was the website meeting on Monday? Also, could you please explain what a Slack huddle is?

@Ashparshp
Copy link
Contributor

@mannika763.. Yes, you're right about the meeting. The Slack huddle is a feature for video call or voice meeting within Slack for quick discussions...

@mannika763
Copy link
Contributor Author

Hi @Muhammed-Moinuddin
I've added padding, font size, and font weight. Could you please let me know if there's anything else that needs adjustment? I'll go through it step by step for clarity.

@l5io
Copy link
Contributor

l5io commented Jul 31, 2024

🚀 Preview for commit 7fc22a3 at: https://66aa5948d596281322069d7d--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@mannika763, Failing!!

@sudhanshutech
Copy link
Member

closing pr since its abandoned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects)
Development

Successfully merging this pull request may close these issues.

Problems with Buttons in sistent
6 participants