Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned text in feature list for mobiles #5660

Closed
wants to merge 3 commits into from
Closed

Aligned text in feature list for mobiles #5660

wants to merge 3 commits into from

Conversation

Harsh-svg988
Copy link
Contributor

@Harsh-svg988 Harsh-svg988 commented Jul 9, 2024

Description

This PR fixes #5651

Notes for Reviewers
I Made the content mobile friendly by applying some css . After two lines it was misaligning which is now fixed and increases overall experience to user

Screenshot 2024-07-10 at 12 16 32 AM

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Harsh-svg988 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 9, 2024

🚀 Preview for commit 3fa1117 at: https://668d8a94d87737d0a9e5297a--layer5.netlify.app

Copy link
Contributor

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes and the fix and please avoid making any additional modifications..

@@ -50,7 +50,7 @@ const FeatureDetails = (props) => {

return (
<FeatureDetailsWrapper>
<div onClick={function () {
<div onClick={function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change anything else in the code. Specifically, avoid making whitespace changes or other lint-related modifications.

@@ -25,7 +25,7 @@ export const details = [
enterprise: <GiCheckMark className="yes-icon" />,
},
{
feature: "Configurable OAuth callbacks",
feature: "Configurable OAuth callbacks ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change anything else in the code. Specifically, avoid making whitespace changes or other lint-related modifications.

@l5io
Copy link
Contributor

l5io commented Jul 10, 2024

🚀 Preview for commit f8ff2b4 at: https://668e7cd74e75530cf9954be1--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 10, 2024

🚀 Preview for commit ad3c7da at: https://668ed2d9330b7a3493169d8d--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@Harsh-svg988 Ain't you creating new branches for new changes?

@Ashparshp
Copy link
Contributor

@Harsh-svg988 Also, please do mention the issue in PR!! So, that it may link with that only!

@Harsh-svg988 Harsh-svg988 deleted the issue/5651 branch July 10, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Text alignment issue in the feature list
3 participants