Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Post Blog] - Meshery 5000 star milestone #5599

Merged
merged 20 commits into from
Jul 29, 2024
Merged

[Fix Post Blog] - Meshery 5000 star milestone #5599

merged 20 commits into from
Jul 29, 2024

Conversation

sandramsc
Copy link
Member

Description

This PR fixes #5598

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sandra Ashipala <[email protected]>
Removed second colon on line 2

Signed-off-by: Sandra Ashipala <[email protected]>
Signed-off-by: Sandra Ashipala <[email protected]>
Signed-off-by: Sandra Ashipala <[email protected]>
Signed-off-by: Sandra Ashipala <[email protected]>
Signed-off-by: Sandra Ashipala <[email protected]>
Signed-off-by: Sandra Ashipala <[email protected]>
Signed-off-by: Sandra Ashipala <[email protected]>
Signed-off-by: Sandra Ashipala <[email protected]>
@github-actions github-actions bot added the area/blog New posts or new blog functionality label Jun 20, 2024
Updated image link to reference correct image

Signed-off-by: Sandra Ashipala <[email protected]>
Signed-off-by: Sandra Ashipala <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jun 21, 2024

🚀 Preview for commit 4393196 at: https://6675c64e6a08c6ccfbeb4929--layer5.netlify.app

Signed-off-by: Sandra Ashipala <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jun 21, 2024

🚀 Preview for commit 5e15904 at: https://6675d2e3543aaedbe5ed753a--layer5.netlify.app

Signed-off-by: Sandra Ashipala <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jun 21, 2024

🚀 Preview for commit e86e5d5 at: https://6675dae5af4203009f07c95e--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jun 21, 2024

🚀 Preview for commit a470ad5 at: https://6675e25402ce9306169beee9--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jun 21, 2024

🚀 Preview for commit 76b05b1 at: https://6675e94c543aaeefa5ed73df--layer5.netlify.app

@sandramsc
Copy link
Member Author

Tried a few times to get the heading "The Journey Has Just Begun" to align on the left, under the headings of the same size above it by using br and p tag to as well as removing the mentioned tags, but it remains aligned on the left. Feedback on how to adjust/fix this is welcome.

imageedit_4_7999326101

@vishalvivekm
Copy link
Member

Thank you for your contribution.
Let's discuss this on Websites's call. Add this as an agenda item into the meeting minutes, if you would :)

@sandramsc sandramsc marked this pull request as ready for review June 24, 2024 12:22
@leecalcote
Copy link
Member

Argh! I should have reviewed this years ago. 🫤 Thank you for this, @sandramsc 👍

@l5io
Copy link
Contributor

l5io commented Jul 23, 2024

🚀 Preview for commit 11fc757 at: https://66a00ef4ad6e3933fe04125f--layer5.netlify.app

Copy link
Member

@hargunkaur286 hargunkaur286 Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. you can make this paragraph start after the image using the break tag. Below are the before and after screenshots
Screenshot 2024-07-25 at 2 02 54 AM Screenshot 2024-07-25 at 2 10 33 AM
  1. you can make the blockquote to float:right, it looks better this way and the problem of moving the "journey has just begun" moving to the next line also gets solved. Here's are the before and after screenshots of the blockquote on the right:
Screenshot 2024-07-25 at 2 03 43 AM Screenshot 2024-07-25 at 1 56 17 AM
  1. you can move the lfx-mentorship image below the "Why Meshery Stands Out" heading with width and height to 50%. This way, there is no unnecessary wastage of space and the content gets filled in and a smaller image looks better. below are the before and after screenshots:
Screenshot 2024-07-25 at 2 04 36 AM Screenshot 2024-07-25 at 2 04 59 AM

Copy link
Member

@hargunkaur286 hargunkaur286 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the content looks good to me!

@sudhanshutech
Copy link
Member

@sandramsc does hargun's feedback looks good?

@leecalcote
Copy link
Member

@hargunkaur286 please apply these formatting changes on @sandramsc's behalf. 👍

@leecalcote leecalcote merged commit 49a5080 into layer5io:master Jul 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog New posts or new blog functionality
Development

Successfully merging this pull request may close these issues.

[Post Blog] - Meshery 5000 star milestone
6 participants