-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy button added #5524
copy button added #5524
Conversation
Signed-off-by: Narasimha <[email protected]>
🚀 Preview for commit d3e9ae5 at: https://66386ba8f6a8fe76cda63d22--layer5.netlify.app |
Adding as an agenda item for websites call. |
@Rexford74 Should we use a copy icon in place of |
Those are fine suggestions @lakshz and I think they can actually fly. |
@Rexford74 Got it. The "Show code" section needs more features, in addition to the Copy button.
|
@lakshz I think 3 buttons are not Nedded ! |
@narasimha-1511 Let's stick to adding a copy button in this PR. We can re-iterate on the other features (if they are needed) moving forward. I've left some comments, for you to solve. |
Signed-off-by: Narasimha <[email protected]>
Hey @narasimha-1511 , let's discuss this on today's website meeting at 12:00 pm GMT / 5:30 PM IST. I am adding this as an agenda item. Please join if you are available during the meet. |
Signed-off-by: Narasimha <[email protected]>
Signed-off-by: Narasimha <[email protected]>
All changes done as requested
🚀 Preview for commit 9b66ec2 at: https://6641c7241107b276d1a0c159--layer5.netlify.app |
Signed-off-by: Narasimha <[email protected]>
importing the color into the svg
🚀 Preview for commit 775d278 at: https://664ee88be3d958cbacaf54f7--layer5.netlify.app |
Signed-off-by: Narasimha <[email protected]>
🚀 Preview for commit 3ae961e at: https://664ef04482a7a5c1e72c673b--layer5.netlify.app |
@narasimha-1511 whats the status here, will you share your progress in upcoming website meet? |
Yeah for sure @sudhanshutech |
@narasimha-1511 what is that status? |
@leecalcote Almost Done , Need a Review |
Recording.2024-05-30.155053.mp4 |
@lakshz we're ready for a final round of review here. |
@narasimha-1511 Instead of showing a toast on copying the code, replace the copy icon with a |
@lakshz Sure ! , i will make the following changes |
|
Hey @sudhanshutech , |
Hey @sudhanshutech i have taken the copy svg from the prototype here! |
Signed-off-by: Narasimha <[email protected]>
@narasimha-1511 any progress? Did you update the changes as we reviewed in call? |
@sudhanshutech The changes have been made! Apologies for the delay. |
Signed-off-by: Narasimha <[email protected]>
🚀 Preview for commit 6b22c78 at: https://66892d26445f1d4074a148e1--layer5.netlify.app |
@narasimha-1511 follow this design to add the copy button , design can be found here: figma) |
Hey @sudhanshutech I have taken the copy icon from the prototype itself that you have given |
The Figma link is this right ? https://www.figma.com/proto/ekm0Hh6M25bSKpP5BcIJom/Sistent-Design-System?page-id=&type=design&node-id=2256-13195&viewport=-8220%2C358%2C0.42&t=f4Bixr8xno32NCYO-1&scaling=scale-down-width the above given link did not work |
its opening fine for me. You can directly go through layer5 figma and under project sistent |
Signed-off-by: Narasimha <[email protected]>
🚀 Preview for commit 2a8895e at: https://668f7b61a59060f07d227a5f--layer5.netlify.app |
@narasimha-1511 please follow these points.
import <Icon> from '@layer5/sistent`
|
@sudhanshutech i have done what you said one last doubt in the image i have placed the icon at the green spot do you want me to place it at the red spot also as you have given in the screenshot? also the icon i used from the layer5/sisent the Cloneicon as you said is not lookig good i have tried to set the height and width still i think the icon is not same as in the figma provided |
Hey @sudhanshutech please review this |
Merge conflict. |
Signed-off-by: Narasimha <[email protected]>
Signed-off-by: Narasimha <[email protected]>
🚀 Preview for commit 2cd0ff5 at: https://669ce81ae2b43959e5078281--layer5.netlify.app |
Megre Conflict Resolved @leecalcote @sudhanshutech @Ashparshp |
@narasimha-1511 Thanks for the update! |
@narasimha-1511 this copy will not be needed now because the code block is updated to use by default copy functionality. Please do take a look |
sure @sudhanshutech |
Make sense. Please do create issue for those. |
Description
This PR fixes #5517
Notes for Reviewers
Signed commits