Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change routes to /products #4739

Closed
wants to merge 1 commit into from
Closed

Conversation

Shreya111111
Copy link

Description

This PR fixes #4690

Notes for Reviewers
change the routes from projects to products.
If there are any further corrections kindly tell accordingly

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shreya111111 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 15, 2023

🚀 Preview for commit 1ad7e0c at: https://64db97c3cb9ad6764bbf8f94--layer5.netlify.app

@Shreya111111
Copy link
Author

@Ghat0tkach plz review the pr and if there are any corrections needed then tell accordingly

Copy link
Member

@Chadha93 Chadha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shreya111111 The internal links will also require an update https://64db97c3cb9ad6764bbf8f94--layer5.netlify.app/projects. For each project path.

@Shreya111111
Copy link
Author

@Chadha93 changing internal links is resulting into breakage

@vishalvivekm
Copy link
Member

@Shreya111111 Let's discuss it on the websites call on Monday. Please add this as an agenda item in the meeting minutes.

@Shreya111111
Copy link
Author

@Ghat0tkach
Copy link
Member

@vishalvivekm yes sure but it says require access in meeting minutes https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

No worries, I've added your agenda . ☺️

@Chadha93
Copy link
Member

@Chadha93 changing internal links is resulting into breakage

@Shreya111111 Since a new products page is developed and we will be archiving this, this update isn't required. Until then feel free to take on new issues.

@Shreya111111
Copy link
Author

@Chadha93 Even I was thinking about the same

@Chadha93
Copy link
Member

@Chadha93 Even I was thinking about the same

@Shreya111111 I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Change route path from /projects to /products
5 participants