Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Twitter's logo has been changed to X #4631 #4679

Closed
wants to merge 0 commits into from

Conversation

parmishh
Copy link
Contributor

@parmishh parmishh commented Aug 1, 2023

updated to latest logo X #4631

Here is the video demo:

Layer5.-.Google.Chrome.2023-08-01.23-55-15.mp4

@l5io
Copy link
Contributor

l5io commented Aug 1, 2023

🚀 Preview for commit b174c70 at: https://64c9516bba4c931fa7511936--layer5.netlify.app

@parmishh
Copy link
Contributor Author

parmishh commented Aug 2, 2023

@leecalcote
@Ghat0tkach

@Ghat0tkach
Copy link
Member

Ghat0tkach commented Aug 2, 2023

@parmishh

Screenshot_20230802-185014.png

The Twitter logo is same in mobile widths.

@parmishh
Copy link
Contributor Author

parmishh commented Aug 2, 2023

because of which the deployed preview doesn't shows the logo. But in my local machine its visible on all screen widths:

Layer5.-.Google.Chrome.2023-08-02.19-04-57.online-video-cutter.com.mp4

@Ghat0tkach
Copy link
Member

@parmishh , I believe you have manually added svg code using HTML inspect tool?
You have changed twitter icon of discuss.layer5.io , Well it was needed there as well.
However as I believe you should check the following files to fix the footer on Actual Website

https://github.com/layer5io/layer5/blob/fb0a68a9d6edd97bb7c02fbc76cff4851b0ec42a/src/assets/images/socialIcons/twitter-dark.svg
https://github.com/layer5io/layer5/blob/fb0a68a9d6edd97bb7c02fbc76cff4851b0ec42a/src/components/SocialLinks/index.js

@Ghat0tkach
Copy link
Member

@parmishh

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@parmishh parmishh closed this Aug 4, 2023
@l5io l5io temporarily deployed to commit August 5, 2023 13:21 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 16:22 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 19:18 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 19:19 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 19:38 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 20:38 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 21:32 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 21:38 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 22:05 Inactive
@l5io l5io temporarily deployed to commit August 5, 2023 22:25 Inactive
@l5io l5io temporarily deployed to commit August 6, 2023 08:43 Inactive
@l5io l5io temporarily deployed to commit August 6, 2023 09:03 Inactive
@l5io l5io temporarily deployed to commit August 6, 2023 09:35 Inactive
@l5io l5io temporarily deployed to commit August 6, 2023 14:10 Inactive
@l5io l5io temporarily deployed to commit August 6, 2023 18:18 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 02:38 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 07:44 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 08:58 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 09:11 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 09:13 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 12:32 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 14:52 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 14:53 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 15:09 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 15:25 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 16:35 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 17:35 Inactive
@l5io l5io temporarily deployed to commit August 7, 2023 18:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants