Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark-mode friendly support for search input field #5734

Closed
leecalcote opened this issue Jul 26, 2024 · 18 comments · Fixed by #5883
Closed

Dark-mode friendly support for search input field #5734

leecalcote opened this issue Jul 26, 2024 · 18 comments · Fixed by #5883
Assignees
Labels
framework/gatsby Gatsby related framework/react React related help wanted Extra attention is needed kind/enhancement New feature or request type/core-styls

Comments

@leecalcote
Copy link
Member

leecalcote commented Jul 26, 2024

Current Behavior

See the https://layer5.io/blog page and it's use of an input field while in dark mode.
See also the site home page and https://layer5.io/cloud-native-management/meshery/integrations for additional uses of a search input field.

Be sure to adhere to the Acceptance Tests below.

Desired Behavior

Screenshot 2024-07-26 at 4 50 08 PM

Acceptance Tests

  1. All search input fields for follow the same dark-mode friendly behavior.
    1. Integrations page
    2. Home page
    3. Blog page

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@leecalcote leecalcote added kind/enhancement New feature or request help wanted Extra attention is needed framework/gatsby Gatsby related framework/react React related type/core-styls labels Jul 26, 2024
@Dipti0704
Copy link

hey @leecalcote I would like to work on this issue, please assign me this issue

@BarryByte
Copy link

hey @leecalcote please assign me this issue.

@hollermay
Copy link

Hey @leecalcote @hargunkaur286 , I'm available for this issue now and have also worked around layer5, you can assign me this

@narasimha-1511
Copy link
Member

Hey @Dipti0704 you have already working on other issue i am assigning this to @BarryByte

@Ashparshp
Copy link
Contributor

Thank you all for your interest in working on this issue!

I apologize for any confusion regarding the assignments. We appreciate your ask and will ensure that future assignments follow the chronological order of requests. For now, @Dipti0704, thank you for your patience. We'll proceed with the issue based on our current process and prioritize assignments accordingly.

Thanks again to @BarryByte, @Indrajeety993648, and @hollermay for your willingness to contribute.

@Ashparshp
Copy link
Contributor

@BarryByte Any updates?

@BarryByte
Copy link

Hello @Ashparshp,
Sorry for the delay in discussing the approach. The issue can be fixed by implementing a dark mode switcher for the entire Blog page. Currently, the background color of the search input field is grey in light mode and white in dark mode, which is not consistent.

Refer to these images for a better understanding of the issue:

Screenshot from 2024-07-28 12-17-26
Screenshot from 2024-07-28 12-17-13

The color hex code does not change when the theme is toggled. Therefore, we need to implement separate changes for the Blog page when the theme is switched.
If i am missing something please add to it.

@Ashparshp
Copy link
Contributor

@sudhanshutech
Copy link
Member

@BarryByte any luck?

@Shubhf
Copy link

Shubhf commented Aug 25, 2024

@sudhanshutech Can I take up this issue?

@Mandeep56Singh
Copy link

@sudhanshutech isn't there any command which can automate assigning issues to people. like .take for assigning issues ?

@Ashparshp
Copy link
Contributor

@Mandeep56Singh, We generally provide access to assign issues to contributors who have shown consistent participation and commitment to the project. This ensures that the right people have the responsibility to manage issues effectively.

@Ashparshp
Copy link
Contributor

@Shubhf, you have already pending issues, please get those done first.

@Ashparshp
Copy link
Contributor

@BarryByte, as we haven't heard back from you, I've unassigned you.

@Ashparshp
Copy link
Contributor

@Mandeep56Singh, intrested on taking?

@Mandeep56Singh
Copy link

@Ashparshp hmm...
ok

@THEBOSS0369
Copy link
Contributor

Hey @leecalcote @Ashparshp @sudhanshutech!
Can i take this issue? I can work on this. Thanks

@Ashparshp
Copy link
Contributor

@THEBOSS0369,

Go ahead please..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/gatsby Gatsby related framework/react React related help wanted Extra attention is needed kind/enhancement New feature or request type/core-styls
Development

Successfully merging a pull request may close this issue.

10 participants