Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new relationships page #234

Merged
merged 14 commits into from
Mar 26, 2024
Merged

Conversation

nwanduka
Copy link
Contributor

@nwanduka nwanduka commented Mar 22, 2024

Notes for Reviewers

This PR fixes #
This is a child page of the Working with Components page. Here I'll be posting images (exported from Figma) that explain the various Meshery Relationships.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Victoria Nduka <[email protected]>
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit d4ccafb
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/66028a4556221b00082da535
😎 Deploy Preview https://deploy-preview-234--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@nwanduka nwanduka marked this pull request as ready for review March 22, 2024 15:11
@iArchitSharma
Copy link
Contributor

@nwanduka This is really great! Can we have descriptions for all the other relationships too, just like we have for the first one?"

@nwanduka
Copy link
Contributor Author

@nwanduka This is really great! Can we have descriptions for all the other relationships too, just like we have for the first one?"

No problem

@vishalvivekm
Copy link
Member

@nwanduka Let's discuss this on websites call. Add this as an agenda item to the meeting minutes, if you would :)

Signed-off-by: Victoria Nduka <[email protected]>
@marblom007
Copy link
Contributor

@nwanduka This is really great! Can we have descriptions for all the other relationships too, just like we have for the first one?"

Great feedback, @iArchitSharma

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@nwanduka
Copy link
Contributor Author

@nwanduka This is really great! Can we have descriptions for all the other relationships too, just like we have for the first one?"

Done @iArchitSharma.

@iArchitSharma iArchitSharma merged commit 9439732 into layer5io:master Mar 26, 2024
6 checks passed
@iArchitSharma
Copy link
Contributor

Thanks @nwanduka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants