fix(community): PrismaVectorStore handle empty array in filter #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:bug
shan-mx
changed the title
FilipZmijewski
pushed a commit
to FilipZmijewski/langchainjs
that referenced
this pull request
Nov 27, 2024
…hain-ai#7254) Co-authored-by: jacoblee93 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an an empty array is passed to IN or NOTIN operator in PrismaVectorStore's filter, it will be directly passed to Prisma.join and cause
TypeError: Expected
join([])to be called with an array of multiple elements, but got an empty arrayThis PR adds a separate logic for handling empty arrays in SQL queries:
libs/langchain-community/src/vectorstores/prisma.ts: Added a condition to check if the array is empty and handleINandNOT INoperators appropriately. For empty arrays,IN ()will returnFALSEandNOT IN ()will returnTRUE.