Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] Add Diskann index for Azure CosmosDB #7150

Closed
wants to merge 1 commit into from
Closed

[draft] Add Diskann index for Azure CosmosDB #7150

wants to merge 1 commit into from

Conversation

crisjy
Copy link
Contributor

@crisjy crisjy commented Nov 5, 2024

Fixes # (issue)

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 5, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 5, 2024 8:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 5, 2024 8:36am

@crisjy crisjy changed the title add Diskann index for Azure CosmosDB [draft] Add Diskann index for Azure CosmosDB Nov 5, 2024
@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Nov 5, 2024
jacoblee93
jacoblee93 approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Is this ready to go?

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Nov 17, 2024
@jacoblee93 jacoblee93 added hold On hold and removed lgtm PRs that are ready to be merged as-is labels Nov 17, 2024
@crisjy
Copy link
Contributor Author

crisjy commented Nov 17, 2024 •
edited
Loading

have a new pr for diskann and test successfully, this pr with be abandoned, thanks a lot! #7225

@crisjy
Copy link
Contributor Author

crisjy commented Nov 17, 2024

#7225

@crisjy crisjy closed this Nov 17, 2024
@crisjy
Copy link
Contributor Author

crisjy commented Nov 17, 2024

have a new pr for this #7225

@crisjy crisjy reopened this Nov 19, 2024
@crisjy crisjy closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases hold On hold size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisjy @jacoblee93