fix(community): For IBM implementation rename variables, remove defaults, fix tests and minor docs fixes

[FilipZmijewski]

Following PR provides following fixes:

• rename variables to camelCase
• remove default values for model
• Update and remove some tests
• update urls in documentation, shrink outputs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-docs	✅ Ready (Inspect)	Visit Preview		Nov 11, 2024 9:52pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-api-refs	⬜️ Ignored (Inspect)			Nov 11, 2024 9:52pm

[FilipZmijewski]

@jacoblee93 Could you please have a look at it or assign someone to this PR? Thank you

[jacoblee93]

Happy to merge since this is a newer integration but noting that this is breaking

[jacoblee93]

Looks like you need to update your notebooks, they are failing our CI check:

tmp/ibm.mts (40,5): Object literal may only specify known properties, but 'max_new_tokens' does not exist in type 'WatsonxInputLLM'. Did you mean to write 'maxNewTokens'?
file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/check_notebook_type_errors.js:101
            const err = new Error("Found type errors in new notebook.");
                        ^

Error: Found type errors in new notebook.
    at checkNotebookTypeErrors (file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/check_notebook_type_errors.js:101:[25](https://github.com/langchain-ai/langchainjs/actions/runs/11612088879/job/32550548449?pr=7129#step:8:26))
    at main (file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/index.js:4:24)
    at file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/index.js:7:10
    at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:337:24)
    at async loadESM (node:internal/process/esm_loader:34:7)
    at async handleMainPromise (node:internal/modules/run_main:106:12) {
  details: "tmp/ibm.mts (40,5): Object literal may only specify known properties, but 'max_new_tokens' does not exist in type 'WatsonxInputLLM'. Did you mean to write 'maxNewTokens'?"
}

Node.js v18.20.4
tmp/ibm.mts (9,3): Object literal may only specify known properties, and 'idOrName' does not exist in type 'WatsonxInputEmbeddings & WatsonxAuth'.
file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/check_notebook_type_errors.js:101
            const err = new Error("Found type errors in new notebook.");
                        ^

Error: Found type errors in new notebook.
    at checkNotebookTypeErrors (file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/check_notebook_type_errors.js:101:25)
    at main (file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/index.js:4:24)
    at file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/index.js:7:10
    at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:[33](https://github.com/langchain-ai/langchainjs/actions/runs/11612088879/job/32550548449?pr=7129#step:8:34)7:24)
    at async loadESM (node:internal/process/esm_loader:34:7)
    at async handleMainPromise (node:internal/modules/run_main:106:12) {
  details: "tmp/ibm.mts (9,3): Object literal may only specify known properties, and 'idOrName' does not exist in type 'WatsonxInputEmbeddings & WatsonxAuth'."
}

[FilipZmijewski]

I fixed the failing notebook

[jacoblee93]

Now failing lint and:

tmp/ibm.mts (39,3): Type '{ maxNewTokens: number; }' is missing the following properties from type 'WatsonxInputLLM': model, serviceUrl, version
file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/check_notebook_type_errors.js:101
            const err = new Error("Found type errors in new notebook.");
                        ^

Error: Found type errors in new notebook.
    at checkNotebookTypeErrors (file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/check_notebook_type_errors.js:101:[25](https://github.com/langchain-ai/langchainjs/actions/runs/11701931027/job/32611842791?pr=7129#step:8:26))
    at main (file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/index.js:4:24)
    at file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/index.js:7:10
    at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:337:24)
    at async loadESM (node:internal/process/esm_loader:34:7)
    at async handleMainPromise (node:internal/modules/run_main:106:12) {
  details: "tmp/ibm.mts (39,3): Type '{ maxNewTokens: number; }' is missing the following properties from type 'WatsonxInputLLM': model, serviceUrl, version"
}

Node.js v18.20.4
tmp/ibm.mts (9,3): Object literal may only specify known properties, and 'idOrName' does not exist in type 'WatsonxInputEmbeddings & WatsonxAuth'.
file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/check_notebook_type_errors.js:101
            const err = new Error("Found type errors in new notebook.");
                        ^

Error: Found type errors in new notebook.
    at checkNotebookTypeErrors (file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/check_notebook_type_errors.js:101:25)
    at main (file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/index.js:4:24)
    at file:///home/runner/work/langchainjs/langchainjs/libs/langchain-scripts/dist/notebooks/index.js:7:10
    at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:[33](https://github.com/langchain-ai/langchainjs/actions/runs/11701931027/job/32611842791?pr=7129#step:8:34)7:24)
    at async loadESM (node:internal/process/esm_loader:34:7)
    at async handleMainPromise (node:internal/modules/run_main:106:12) {
  details: "tmp/ibm.mts (9,3): Object literal may only specify known properties, and 'idOrName' does not exist in type 'WatsonxInputEmbeddings & WatsonxAuth'."
}

[FilipZmijewski]

I am just fixing the notebooks but lint doesn't seem to be a problem with our implementation:

/home/runner/work/langchainjs/langchainjs/libs/langchain-xai/src/tests/chat_models_structured_output.int.test.ts
Error:   2:1  error  'zod-to-json-schema' should be listed in the project's dependencies. Run 'npm i -S zod-to-json-schema' to add it  import/no-extraneous-dependencies 

[jacoblee93]

CC @bracesproul above

[vercel]

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

[FilipZmijewski]

CC @bracesproul above

any news why the lint would be failing?

[jacoblee93]

Have been told it merging main should fix it, have just done so!

[jacoblee93]

Thanks!

[FilipZmijewski]

Thank you!