Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move off bower #189

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from
Open

Move off bower #189

wants to merge 3 commits into from

Commits on Jun 9, 2018

  1. 🎨Re-orginize package.json 

    I just perfer to see the dependancies at the bottom as they can tend to grow
and it makes it easier to view the more important stuff like meta info about
the package and the scripts in a terminal editor if they are at the top
    Brad van der Laan committed Jun 9, 2018
    Configuration menu
    Copy the full SHA
    b67985a View commit details
    Browse the repository at this point in the history

  2. Move from Bower to NPM 

    This change set removes 🔥 Bower as the dependancy package manager and
switches over to NPM. Bower requiers all packages to be in git and pulls
them out of a public git repo. NPM on the other hand is a registry of
packages and it has become the go to for JS package dependancy for both
Node and Browser applications. The Bower website even suggests moving
off Bower in favor of NPM/Yarn.
    Brad van der Laan committed Jun 9, 2018
    Configuration menu
    Copy the full SHA
    e7aed6b View commit details
    Browse the repository at this point in the history

  3. 💚Fix Karam Tests 

    With the change to move off bower I had to update angular-smart-table  because
NPM did not have the very old version we were using. The oldest 1.x version it
had was 1.4.12.

In angular-smart-table  1.4.2 however they refactored their smart-table.module.js
file to no longer pass in the angular global but instead refernce the ng
variable directly. This caused an issue with the Karma config as ng  is unknown.

Looking at lorenzofox3/Smart-Table@13da8c9#diff-40dfb1c53004f1488cbe6eb300b286dd
I see what they did for their Karma test config so this change set is just
copying that to ensure that the angular-smart-table  module is imported
propertly in the tests. This does not seem to be an issue in prod.
    Brad van der Laan committed Jun 9, 2018
    Configuration menu
    Copy the full SHA
    77725ee View commit details
    Browse the repository at this point in the history