[release-v0.18] fix: replacing of namespace annotation when openshift-cnv namespace is set #687
Conversation
…t in ssp CR When ssp CR contains kubevirt namespace as a target namespace for pipelines, ssp operator recognized this namespace as user defined and deployed configmaps and roleBindings to a single namespace, instead of two namespaces. That broke our default pipeline flow. This change adds a check if the pipeline namespace in the CR is kubevirt, then it is not used as a user defined namespace and kubevirt.io/tekton-piplines-deploy-namespace annotation is used instead. rename kubevirt.io/deploy-namespace annotation to kubevirt.io/tekton-piplines-deploy-namespace Signed-off-by: Karel Simon <[email protected]>
kubevirt-bot
added
release-note-none
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@kubevirt-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-functests |
|
@ksimon1: No presubmit jobs available for kubevirt/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #683
/assign ksimon1