Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move to kubevirt v1.0.0 #649

Merged
merged 2 commits into from
Aug 16, 2023
Merged

chore: Move to kubevirt v1.0.0 #649

merged 2 commits into from
Aug 16, 2023

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Aug 9, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #601

Special notes for your reviewer:

Just waiting on the final CDI release.

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 9, 2023
@akrejcir akrejcir mentioned this pull request Aug 15, 2023
Merged
@lyarwood lyarwood marked this pull request as ready for review August 15, 2023 14:27
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

0xFelix
0xFelix reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@akrejcir
Copy link
Collaborator

/lgtm

/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@kubevirt-bot kubevirt-bot merged commit 11c2e89 into kubevirt:main Aug 16, 2023
4 checks passed
@akrejcir
Copy link
Collaborator

/cherry-pick release-v0.18

@kubevirt-bot kubevirt-bot mentioned this pull request Aug 16, 2023
Merged
@kubevirt-bot
Copy link
Contributor

@akrejcir: new pull request created: #660

In response to this:

/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@akrejcir akrejcir Awaiting requested review from akrejcir

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move kubevirt.io/api to v1.0.0 and kubevirt.io/containerized-data-importer-api to v1.57.0 with GA
4 participants
@lyarwood @kubevirt-bot @akrejcir @0xFelix