Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common-instancetypes to v0.3.2 #642

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Update common-instancetypes to v0.3.2 #642

merged 1 commit into from
Aug 17, 2023

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Aug 2, 2023

common-instancetypes: Update bundle to v0.3.2

https://github.com/kubevirt/common-instancetypes/releases/tag/v0.3.2

Release note:

Update common-instancetypes bundle to v0.3.2

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 2, 2023
@akrejcir
Copy link
Collaborator

akrejcir commented Aug 2, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
0xFelix
0xFelix approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@lyarwood
Copy link
Member Author

lyarwood commented Aug 2, 2023

/retest-required

6 similar comments
@0xFelix
Copy link
Member

0xFelix commented Aug 3, 2023

/retest-required

@lyarwood
Copy link
Member Author

lyarwood commented Aug 7, 2023

/retest-required

@lyarwood
Copy link
Member Author

lyarwood commented Aug 9, 2023

/retest-required

@lyarwood
Copy link
Member Author

/retest-required

@lyarwood
Copy link
Member Author

/retest-required

@lyarwood
Copy link
Member Author

/retest-required

@lyarwood
Copy link
Member Author

/test e2e-functests

@kubevirt-bot
Copy link
Contributor

@lyarwood: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyarwood
Copy link
Member Author

@akrejcir @0xFelix if either of you have time tomorrow I'm struggling to get to the bottom of this failure.

I can reproduce what I think is the same behaviour locally by deploying the sample SSP CR before running func tests. AFAICT this is breaking the clean up of the common instance type resources (and a few others).

I'm struggling to understand why these resources aren't owned by the func test SSP CR by the time this test runs and I can't see any obvious recent changes that might be causing this change in behaviour since v0.3.1 landed.

@lyarwood lyarwood force-pushed the update-common-instancetypes-v0.3.2 branch from 7794332 to 0ca26dd Compare August 16, 2023 10:48
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@lyarwood
Copy link
Member Author

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@lyarwood lyarwood force-pushed the update-common-instancetypes-v0.3.2 branch from 0ca26dd to 727531f Compare August 16, 2023 11:43
@lyarwood
common-instancetypes: Update bundle to version v0.3.2
62cda7e 
Signed-off-by: common-instancetypes Release Automation <[email protected]>
@lyarwood lyarwood force-pushed the update-common-instancetypes-v0.3.2 branch from 727531f to 62cda7e Compare August 16, 2023 13:41
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lyarwood
Copy link
Member Author

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@lyarwood
Copy link
Member Author

lyarwood commented Aug 16, 2023 •
edited
Loading

@akrejcir @0xFelix okay so the rebase fixed the weird failures, if either of you can hit this again.

0xFelix
0xFelix approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@kubevirt-bot kubevirt-bot merged commit 268ceab into kubevirt:main Aug 17, 2023
4 checks passed
@lyarwood
Copy link
Member Author

lyarwood commented Aug 17, 2023 •
edited
Loading

/cherry-pick release-v0.18

@kubevirt-bot
Copy link
Contributor

@lyarwood: cannot checkout release-v0.18.0: error checking out release-v0.18.0: exit status 1. output: error: pathspec 'release-v0.18.0' did not match any file(s) known to git

In response to this:

/cherry-pick release-v0.18.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyarwood
Copy link
Member Author

/cherry-pick release-v0.18

@kubevirt-bot
Copy link
Contributor

@lyarwood: new pull request created: #662

In response to this:

/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@codingben codingben Awaiting requested review from codingben

Assignees

@0xFelix 0xFelix

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyarwood @akrejcir @kubevirt-bot @0xFelix