refactor(CNV-31248): remove namespace annotation

[codingben]

What this PR does / why we need it:

Remove vm-console-proxy-namespace annotation that
is no longer relevant since a new released VM
console proxy is no longer require namespace
to operate, by default it was kubevirt as it
required an access to virt-handler (and also
virt-handler certificates).

Jira-Url: https://issues.redhat.com/browse/CNV-31248

Release note:

Remove vm-console-proxy-namespace annotation

[codingben]

/cc @0xFelix

[0xFelix]

IIUC GetVmConsoleProxyNamespace should be dropped from the test suite and instead GetNamespace should be used, because vm-console-proxy is deployed in the same namespace as SSP?

[codingben]

IIUC GetVmConsoleProxyNamespace should be dropped from the test suite and instead GetNamespace should be used, because vm-console-proxy is deployed in the same namespace as SSP?

You're right, thanks! I forgot about it.

[codingben]

There is an issue with functional tests, I'm trying to debug it. The tests aren't running locally and operator is stuck on validate create logs.

[codingben]

Okay so the functional tests are failing because namespace annotation was removed, and a newer version of vm-console-proxy wasn't released yet, so it's failing to get the virt-handler certificates.

@akrejcir will do a new release of vm-console-proxy, now it's v0.2.0 [1].

[1] https://quay.io/repository/kubevirt/vm-console-proxy

[codingben]

/retest

[codingben]

This PR depends on #645, since we had major functionality changes in vm-console-proxy that wasn't updated in ssp-operator as well (e.g. there is no /token endpoint, but we have functional tests for it in ssp-operator that is failing).

[0xFelix]

Actually there is a /vnc endpoint now, which /token was renamed to. It should still be accessible, see https://github.com/kubevirt/vm-console-proxy/blob/main/docs/api.md#example.

[akrejcir]

PR #645 has been merged.

[codingben]

PR #645 has been merged.

I rebased and resolved conflicts. make container-build successfully passed locally.

[akrejcir]

The VmConsoleProxyNamespace() function in /tests/env/env.go is not used anymore and can be removed. The same applies for any mention of environment variable VM_CONSOLE_PROXY_NAMESPACE

[akrejcir]

/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [akrejcir]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codingben]

I see CI job are failing and locally as well, functional tests:

Summarizing 5 Failures:
  [FAIL] VM Console Proxy Operand Resource creation created cluster resource [It] [test_id:9848] service account
  /home/*/GitHub/codingben/ssp-operator/tests/vm_console_proxy_test.go:156
  [FAIL] VM Console Proxy Operand Resource deletion recreate after delete [It] [test_id:9866] config map
  /home/*/GitHub/codingben/ssp-operator/tests/tests_common_test.go:105
  [FAIL] VM Console Proxy Operand Resource change should restore modified resource [It] [test_id:9871] config map
  /home/*/GitHub/codingben/ssp-operator/tests/tests_common_test.go:182
  [FAIL] VM Console Proxy Operand Resource change should restore modified app labels [It] [test_id:9884] config map
  /home/*/GitHub/codingben/ssp-operator/tests/labels_test.go:78
  [FAIL] VM Console Proxy Operand Accessing proxy [It] [test_id:TODO] should be able to access /vnc endpoint
  /home/*/GitHub/codingben/ssp-operator/tests/vm_console_proxy_test.go:336

Ran 35 of 289 Specs in 423.144 seconds
FAIL! -- 30 Passed | 5 Failed | 1 Pending | 253 Skipped

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[akrejcir]

/lgtm

[akrejcir]

/cherry-pick release-v0.18

[kubevirt-bot]

@akrejcir: once the present PR merges, I will cherry-pick it on top of release-v0.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubevirt-bot]

@akrejcir: #634 failed to apply on top of branch "release-v0.18":

Applying: refactor(CNV-31248): remove namespace annotation
Using index info to reconstruct a base tree...
M	automation/e2e-upgrade-functests/run.sh
M	data/olm-catalog/ssp-operator.clusterserviceversion.yaml
A	docs/configuration.md
M	internal/operands/vm-console-proxy/reconcile.go
Falling back to patching base and 3-way merge...
Auto-merging internal/operands/vm-console-proxy/reconcile.go
CONFLICT (modify/delete): docs/configuration.md deleted in HEAD and modified in refactor(CNV-31248): remove namespace annotation. Version refactor(CNV-31248): remove namespace annotation of docs/configuration.md left in tree.
Auto-merging data/olm-catalog/ssp-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in data/olm-catalog/ssp-operator.clusterserviceversion.yaml
Auto-merging automation/e2e-upgrade-functests/run.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 refactor(CNV-31248): remove namespace annotation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.