Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump tekton to v1 #296

Merged
merged 3 commits into from
Jan 5, 2024
Merged

feat: Bump tekton to v1 #296

merged 3 commits into from
Jan 5, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Dec 11, 2023

What this PR does / why we need it:
Bump tekton to v1
This PR updates package to latest version and adjust code to work with tekton v1 instead of v1beta1

Release note:

NONE

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Dec 11, 2023
@openshift-ci openshift-ci bot requested a review from akrejcir December 11, 2023 10:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2023
@0xFelix
Copy link
Member

0xFelix commented Dec 11, 2023

/retest

1 similar comment
@ksimon1
Copy link
Member Author

ksimon1 commented Dec 11, 2023

/retest

Copy link
Member

@codingben codingben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, codingben, ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codingben
Copy link
Member

/test e2e-tests

@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

1 similar comment
@0xFelix
Copy link
Member

0xFelix commented Dec 21, 2023

/retest

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Jan 2, 2024

/retest

1 similar comment
@ksimon1
Copy link
Member Author

ksimon1 commented Jan 2, 2024

/retest

Adjust code to use github.com/tektoncd/pipeline/pkg/apis/pipeline/v1
instead of v1beta1

Signed-off-by: Karel Simon <[email protected]>
@ksimon1
Copy link
Member Author

ksimon1 commented Jan 3, 2024

/retest

2 similar comments
@ksimon1
Copy link
Member Author

ksimon1 commented Jan 3, 2024

/retest

@ksimon1
Copy link
Member Author

ksimon1 commented Jan 4, 2024

/retest

@akrejcir
Copy link
Contributor

akrejcir commented Jan 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
@ksimon1 ksimon1 merged commit 4cb0442 into kubevirt:main Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants