Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8] dataImportCronTemplates: Remove CentOS 7 & stream 8 #3070

Open
wants to merge 2 commits into
base: release-1.8
Choose a base branch
from

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Aug 26, 2024

What this PR does / why we need it:

This is a manual backport of #3048.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

https://issues.redhat.com/browse/CNV-45852

Release note:

CentOS 7 & CentOS stream 8 are now EOL so the associated `DataImportCronTemplates` have been removed

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 26, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10560324470

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.646%

Totals Coverage Status
Change from base Build 8703919399: 0.0%
Covered Lines: 4690
Relevant Lines: 5476

💛 - Coveralls

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 26, 2024

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lyarwood and others added 2 commits August 26, 2024 15:05
Both releases are now EOL with their associated containerdisks also
deprecated ahead of removal in the near future:

kubevirt/containerdisks#154
kubevirt/containerdisks#152

Conflicts:
  assets/dataImportCronTemplates/dataImportCronTemplates.yaml
  tests/func-tests/golden_image_test.go
  hack/check_golden_images.sh

NOTE: The conflict is due to commits 2e339b9 and 2057518 missing in
release-1.8.

Signed-off-by: Lee Yarwood <[email protected]>
Co-authored-by: Felix Matouschek <[email protected]>
The source of this image stream is also changed to the smaller and more
up to date containerdisks project version of the image.

Conflicts:
  tests/func-tests/golden_image_test.go
  hack/check_golden_images.sh

NOTE: The conflict is due to commit 2e339b9 missing in release-1.8.

Signed-off-by: Lee Yarwood <[email protected]>
Co-authored-by: Felix Matouschek <[email protected]>
@0xFelix 0xFelix force-pushed the remove-centos-7-centos-stream-8-dics-1.8 branch from 7c3f4f0 to a026fce Compare August 26, 2024 13:05
Copy link

sonarcloud bot commented Aug 26, 2024

@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@hco-bot
Copy link
Collaborator

hco-bot commented Aug 26, 2024

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@0xFelix
Copy link
Member Author

0xFelix commented Aug 27, 2024

/retest-required

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 27, 2024

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 27, 2024

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@0xFelix
Copy link
Member Author

0xFelix commented Aug 27, 2024

/retest

@0xFelix
Copy link
Member Author

0xFelix commented Aug 28, 2024

@tiraboschi The CI failures do not seem to be related to my changes. I see GLIBC mismatch errors. Are these lanes still able to pass at all?

@0xFelix
Copy link
Member Author

0xFelix commented Sep 11, 2024

/retest

Copy link

openshift-ci bot commented Sep 11, 2024

@0xFelix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-prev-index-azure a026fce link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-image-index-gcp a026fce link true /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-sno-azure a026fce link false /test hco-e2e-image-index-sno-azure
ci/prow/hco-e2e-image-index-sno-aws a026fce link false /test hco-e2e-image-index-sno-aws
ci/prow/hco-e2e-upgrade-prev-index-sno-aws a026fce link false /test hco-e2e-upgrade-prev-index-sno-aws
ci/prow/hco-e2e-image-index-aws a026fce link true /test hco-e2e-image-index-aws
ci/prow/hco-e2e-upgrade-prev-index-sno-azure a026fce link false /test hco-e2e-upgrade-prev-index-sno-azure
ci/prow/hco-e2e-image-index-azure a026fce link true /test hco-e2e-image-index-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants