[WIP] Support unmarshall multiple yaml documents

[krzyzacy]

looks like go-yaml/yaml#301 added the support already

(fighting with dep)

[fejta]

I do not think switching out the yaml package will go well

[BenTheElder]

+1 to @fejta's comment. we can use the existing marshalling / unmarshalling and just have a separate step to split the file into byte blobs that are seperate documents. they're just delimited by ---\n

[BenTheElder]

actual spec details on this: http://yaml.org/spec/1.2/spec.html#id2760395

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[krzyzacy]

@fejta hummm, why?

I mean I can do what @BenTheElder has suggested, but why we ping to a specific version of yaml library? aka what can break?

[krzyzacy]

/hold

[k8s-ci-robot]

@krzyzacy: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-test-infra-lint	79485cb	link	/test pull-test-infra-lint
pull-test-infra-bazel	79485cb	link	/test pull-test-infra-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[krzyzacy]

/shrug
@stevekuznetsov forgot ghodss/yaml does this jsonToYaml thing, and they are not caught up with upstream go-yaml :-\

I'd prefer do the split ourselves (it's pretty straight forward) until they update the library

[stevekuznetsov]

Can we do the split as a patch on top of the vendored code? Then propose the changes upstream? There's no good reason we should work around the library instead of trying to improve it for all :)

[krzyzacy]

@stevekuznetsov do we suppose to edit vendor code?

[krzyzacy]

hummmmm seems it's not going to be easy if we want to use goyaml's decoder in ghodss/yaml

https://github.com/go-yaml/yaml/blob/v2/yaml.go#L95 the goyaml parser struct is unexported, and I don't really have a way to wrap around https://github.com/go-yaml/yaml/blob/v2/yaml.go#L119-L135 unless I write my own parser :-/

opened ghodss/yaml#31

[krzyzacy]

/shrug
I see k8s already does that in https://github.com/kubernetes/apimachinery/blob/master/pkg/util/yaml/decoder.go, probably just use that instead

[krzyzacy]

don't need to bump go-yaml, will switch to the other branch instead