Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP-DO NOT MERGE] Refactoring bash to python #119

Closed
wants to merge 1 commit into from
Closed

[WIP-DO NOT MERGE] Refactoring bash to python #119

wants to merge 1 commit into from

Conversation

markjacksonfishing
Copy link

Signed-off-by: markyjackson-taulia [email protected]

[WIP-DO NOT MERGE] Refactoring bash to python for gen-content.sh
Still more work to do

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markyjackson-taulia
To complete the pull request process, please assign mrbobbytables
You can assign the PR to them by writing /assign @mrbobbytables in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 11, 2020
@markjacksonfishing
Copy link
Author

/assign @markyjackson-taulia

@markjacksonfishing
Copy link
Author

/assign @mrbobbytables

@markjacksonfishing
Copy link
Author

This is for issue #93

@markjacksonfishing
Copy link
Author

/milestone v1.19

@markjacksonfishing
Copy link
Author

@mrbobbytables I remember you saying something about wanting to remove a lot of the grep items but I wanted to be sure before I headed down that path.

Also going to ping Laura (cannot tag her) for another set of eyes

@mrbobbytables
Copy link
Member

From previous discussion, going to go ahead and close this out for now -- We will revisit later.

Thanks @markyjackson-taulia ❤️
/close

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closed this PR.

In response to this:

From previous discussion, going to go ahead and close this out for now -- We will revisit later.

Thanks @markyjackson-taulia ❤️
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants