Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 [release-1.9] Update md link check for release-1.9 #11481

Merged
merged 1 commit into from
Nov 26, 2024
Merged

🌱 [release-1.9] Update md link check for release-1.9 #11481

merged 1 commit into from
Nov 26, 2024

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Nov 26, 2024 •
edited
Loading

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2024
@cahillsf
Copy link
Member Author

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing and removed do-not-merge/needs-area PR is missing an area label labels Nov 26, 2024
@cahillsf cahillsf marked this pull request as ready for review November 26, 2024 16:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024
Sunnatillo
Sunnatillo reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Sunnatillo
Sunnatillo reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf15032e30577ef7d1af99e80a3d8be761ed4d3a

chandankumar4
chandankumar4 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@chandankumar4 chandankumar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cahillsf cahillsf changed the title 🌱 Update md link check for release-1.9 🌱 [release-1.9] Update md link check for release-1.9 Nov 26, 2024
@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9a272fb into kubernetes-sigs:release-1.9 Nov 26, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@chandankumar4 chandankumar4 chandankumar4 approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@vincepri vincepri Awaiting requested review from vincepri

@enxebre enxebre Awaiting requested review from enxebre

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@chandankumar4 chandankumar4

@Sunnatillo Sunnatillo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cahillsf @k8s-ci-robot @chrischdi @chandankumar4 @Sunnatillo