Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Set Machine's BootstrapReady when there is no ConfigRef #11459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Set Machine's BootstrapReady when there is no ConfigRef #11459

wants to merge 1 commit into from

Commits on Nov 28, 2024

  1. Set Machine's BootstrapReady when there is no ConfigRef 

    If there is no ConfigRef but the bootstrap data secret is set by the
user (instead of a bootstrap provider), then BootstrapReady should be
true. This is the case for MachineSet, and was originally the case for
Machine since 5113f80. However, in
d93eadc this changed as a side effect
of ensuring that bootstrap config object can continue to be reconciled
after the bootstrap provider has produced the bootstrap data secret.

This change ensures that, once a bootstrap data secret exists, in the
case of a ConfigRef it can still be reconciled, while in the case there
is no ConfigRef, BootstrapReady is set.

Signed-off-by: Zane Bitter <[email protected]>
    @zaneb
    zaneb committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f74c2e3 View commit details
    Browse the repository at this point in the history