Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add support for v1beta2 conditions to clusterctl describe #11277

Merged
merged 2 commits into from
Nov 25, 2024
Merged

✨ Add support for v1beta2 conditions to clusterctl describe #11277

merged 2 commits into from
Nov 25, 2024
+1,728 −150

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Add supports for v1beta2 conditions to clusterctl describe

Which issue(s) this PR fixes*:
Rif #11105

/area clusterctl

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 8, 2024
@fabriziopandini fabriziopandini mentioned this pull request Oct 8, 2024
Open
59 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2024
@fabriziopandini fabriziopandini force-pushed the add-v1beta2-to-clusterctl-describe branch from 5955711 to 03d2f84 Compare November 22, 2024 14:48
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2024
@fabriziopandini fabriziopandini force-pushed the add-v1beta2-to-clusterctl-describe branch from 03d2f84 to 19f02b6 Compare November 22, 2024 14:57
@fabriziopandini fabriziopandini changed the title [WIP] ✨ Add support for v1beta2 conditions to clusterctl describe ✨ Add support for v1beta2 conditions to clusterctl describe Nov 22, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
@chrischdi
Copy link
Member

Just some nits, otherwise lgtm

chrischdi
chrischdi reviewed Nov 25, 2024
View reviewed changes
cmd/clusterctl/client/tree/tree.go Outdated Show resolved Hide resolved
cmd/clusterctl/client/tree/util.go Show resolved Hide resolved
cmd/clusterctl/cmd/describe_cluster.go Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 4af631c link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6951351f264183d1d2ac69e7bc2b10f7cedea6cb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7a7ba01 into kubernetes-sigs:main Nov 25, 2024
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 25, 2024
@chrischdi chrischdi mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @chrischdi @k8s-ci-robot