chore: support registry and tag overrides in makefile #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Salas <[email protected]>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
damdo
reviewed
Nov 13, 2024
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
@cpanato @richardcase is there a way we could have a patch release after this PR is merged, since the last one was already 3 weeks ago? It would help us to fix a bug in our custom image-building workflow. |
cpanato
approved these changes
Nov 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
This change adds support for
STAGING_REGISTRY/PROD_REGISTRYandRELEASE_TAGoverrides in theMakefile. The current configuration does not allow setting a different value for these parameters via environment variables. This is a limitation in, for example, an air-gapped environment where a user may want to create their own release of the provider and reference an image stored in a custom registry.It should not affect any existing use cases as the default value is unchanged.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
TODOs:
Release note: