Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support setting loggingService and monitoringService #1292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support setting loggingService and monitoringService #1292

wants to merge 1 commit into from

Conversation

darkweaver87
Copy link

@darkweaver87 darkweaver87 commented Jul 22, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

On GKE, loggingService and monitoringService are enabled by default. Some people might don't need it as they have their own observability stack. Moreover, the installed services are not working on ARM architectures.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
I'm not sure if I should add unit tests and where ? gcpmanagedcontrolplane_webhook don't have tests, should I create it ?

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

feat: support setting loggingService and monitoringService

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darkweaver87
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @darkweaver87!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @darkweaver87. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 22, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 3e1996f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66a78b0e94a9be0008618645
😎 Deploy Preview https://deploy-preview-1292--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 22, 2024
@darkweaver87 darkweaver87 force-pushed the feat/logging branch 2 times, most recently from 5c4c206 to 3f9485b Compare July 22, 2024 12:12
@salasberryfin
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2024
@salasberryfin
Copy link
Contributor

Thanks for the PR @darkweaver87. Looks like you need to fix some linting issues and run make generate.

@darkweaver87
Copy link
Author

darkweaver87 commented Jul 22, 2024 •
edited
Loading

@salasberryfin thank you for guiding me on this and sorry :-)
It should be better now :-)

@richardcase
Copy link
Member

@darkweaver87 - thanks for this change. Would you be able to change the commit messages so they don't include the @

richardcase
richardcase reviewed Jul 24, 2024
View reviewed changes
exp/api/v1beta1/gcpmanagedcontrolplane_types.go Outdated
@@ -148,6 +148,16 @@ type GCPManagedControlPlaneSpec struct {
// This feature is disabled if this field is not specified.
// +optional
MasterAuthorizedNetworksConfig *MasterAuthorizedNetworksConfig `json:"master_authorized_networks_config,omitempty"`
// LoggingService represents configuration of logging service feature of the GKE cluster.
// Possible values: none, logging.googleapis.com/kubernetes (default for GKE 1.14+), logging.googleapis.com (default for GKE < 1.14).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have some validation for this? Or shall we assume it's a cluster greater than 1.14 and so the only values allowed would be:

  • none
  • logging.googleapis.com/kubernetes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the google documentation we can't use logging.googleapis.com for GKE > 1.14 so yes it makes sense. I'll update the PR.
Thanks.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2024
@darkweaver87 darkweaver87 force-pushed the feat/logging branch 2 times, most recently from e2c188d to fc2e057 Compare July 25, 2024 08:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 25, 2024
@richardcase
Copy link
Member

Thaks @darkweaver87, this looks good to me. Before we merge would you be able to squash your commits?

@darkweaver87
Copy link
Author

@richardcase , yes surely. Thanks :-)

@mloiseleur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2024
@mloiseleur
Copy link
Contributor

@richardcase You said it looked good to you. Would you please do the final approve on this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur left review comments

@dims dims Awaiting requested review from dims

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@mloiseleur mloiseleur

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darkweaver87 @k8s-ci-robot @salasberryfin @richardcase @mloiseleur