Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nawazkh to maintainers #5224

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Nawaz has consistently demonstrated value across a broad range of the CAPZ project.

Features:

Altogether Nawaz has landed 78 PRs throughout his time working on CAPZ:

Thank you Nawaz!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

Signed-off-by: Jack Francis <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@jackfrancis
Copy link
Contributor Author

@mboersma
Copy link
Contributor

/lgtm

Yes please! @nawazkh has been a strong and consistent pillar of CAPZ and I'm excited to have him join the maintainers. 👍🏻

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b9b98ed06fb65133196171f5c60ae54f7cfa0d8c

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 31, 2024

+1, LGTM

@willie-yao
Copy link
Contributor

Huge +1 from me! Nawaz has made so many impactful contributions to the project especially with his recent work on the ilb stuff! 🚀

/lgtm

Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
🚀

@jsturtevant
Copy link
Contributor

/lgtm
you've had broad contributions and always willing to dive into the chop wood, carry water tasks

@Jont828
Copy link
Contributor

Jont828 commented Nov 1, 2024

/lgtm

Congrats! 🚀🚀🚀

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit ea98959 into kubernetes-sigs:main Nov 1, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants