Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dataplane and udp server builds on arm64 #261

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aryan9600
Copy link
Member

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aryan9600

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
Containerfile.dataplane Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
@aryan9600 aryan9600 changed the title fix dataplane builds on arm64 fix dataplane and udp server builds on arm64 Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2024
@Gladdstone
Copy link
Contributor

this needs to be llvm-19, now 😔

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2024
@aryan9600
Copy link
Member Author

this is ready for another round of review @shaneutt @EandrewJones

@aryan9600 aryan9600 force-pushed the fix-arm64-build branch 5 times, most recently from 886032c to a943c20 Compare September 21, 2024 17:43
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this isn't going to be super straightforward (I say this because it seems like we've had some issues) then I'm almost inclined to say we should wait until someone else comes along and requests arm64 builds before we spend more time on this? I'm kinda fine either way, but I just wanted to point out that I think it's fair to say "oh, this wasn't the 2-second thing it was supposed to be, we can handle it later since it's not in the critical path".

@EandrewJones
Copy link
Contributor

EandrewJones commented Oct 4, 2024 via email

@shaneutt
Copy link
Member

shaneutt commented Oct 4, 2024

Oh I didn't realize Flynn needed this (the description was empty! there wasn't an issue for it!). I'll go chat with him about it, if this unblocks him then I would be in favor of pressing on actually, as I don't want anyone who's interested in the project to be "locked out" because of their system architecture if we can avoid it within a reasonable amount of effort.

@EandrewJones
Copy link
Contributor

EandrewJones commented Oct 4, 2024 via email

@shaneutt
Copy link
Member

shaneutt commented Oct 4, 2024

So yeah I talked with Flynn and all his development/testing is done on ARM64 systems so unblocking a community member is a great reason to continue. I did realize however that without the finished Rust control-plane the value of any builds is a bit dubious so just keep that in mind (but otherwise godspeed).

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2024
.github/workflows/build.yaml Show resolved Hide resolved
@@ -51,3 +51,25 @@ jobs:
- name: Run Tests
run: |
make test
docker-build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it relates to the above comment: we should create a follow-up issue for runner configurations, or whatever we need to significantly reduce these build times.

@shaneutt
Copy link
Member

Everything else looks good. Just the build trigger changes and the follow up for runners and then LGTM.

Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

6 participants