-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dataplane and udp server builds on arm64 #261
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aryan9600 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b09c536
to
9627789
Compare
9627789
to
e4dcefe
Compare
e4dcefe
to
bf09de9
Compare
bf09de9
to
fe69d9a
Compare
this needs to be llvm-19, now 😔 |
fe69d9a
to
654f65a
Compare
654f65a
to
ec3308e
Compare
this is ready for another round of review @shaneutt @EandrewJones |
886032c
to
a943c20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this isn't going to be super straightforward (I say this because it seems like we've had some issues) then I'm almost inclined to say we should wait until someone else comes along and requests arm64 builds before we spend more time on this? I'm kinda fine either way, but I just wanted to point out that I think it's fair to say "oh, this wasn't the 2-second thing it was supposed to be, we can handle it later since it's not in the critical path".
Tell that to Flynn ;)
But I agree. arm64 builds are notoriously painful to maintain, in my
experience.
Best
Evan Jones
Website: www.ea-jones.com
…On Fri, Oct 4, 2024 at 11:54 AM Shane Utt ***@***.***> wrote:
***@***.**** commented on this pull request.
If this isn't going to be super straightforward (I say this because it
seems like we've had some issues) then I'm almost inclined to say we should
wait until someone else comes along and requests arm64 builds before we
spend more time on this?
—
Reply to this email directly, view it on GitHub
<#261 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ2T6AMFWZEQOSW7ODWZSXDZZ3QABAVCNFSM6AAAAABK6UAWKGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBYHA4TMMZRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Oh I didn't realize Flynn needed this (the description was empty! there wasn't an issue for it!). I'll go chat with him about it, if this unblocks him then I would be in favor of pressing on actually, as I don't want anyone who's interested in the project to be "locked out" because of their system architecture if we can avoid it within a reasonable amount of effort. |
My understanding is @aryan9600 initially hopped on this because Flynn
mentioned the build was broken for him. And Sanskar has been chasing llvm
versions ever since. We should confirm.
Best
Evan Jones
Website: www.ea-jones.com
…On Fri, Oct 4, 2024 at 1:58 PM Shane Utt ***@***.***> wrote:
Oh I didn't realize Flynn needed this (the description was empty! there
wasn't an issue for it!). I'll go chat with him about it, if this unblocks
him then I would be in favor of pressing on actually, as I don't want
anyone who's interested in the project to be "locked out" because of their
system architecture if we can avoid it within a reasonable amount of effort.
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ2T6AJTXE3XBSSK5U3NT6DZZ36PPAVCNFSM6AAAAABK6UAWKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGU3TOOJTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
So yeah I talked with Flynn and all his development/testing is done on ARM64 systems so unblocking a community member is a great reason to continue. I did realize however that without the finished Rust control-plane the value of any builds is a bit dubious so just keep that in mind (but otherwise godspeed). |
72ff6e5
to
8e0093f
Compare
8e0093f
to
d864073
Compare
@@ -51,3 +51,25 @@ jobs: | |||
- name: Run Tests | |||
run: | | |||
make test | |||
docker-build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it relates to the above comment: we should create a follow-up issue for runner configurations, or whatever we need to significantly reduce these build times.
Everything else looks good. Just the build trigger changes and the follow up for runners and then LGTM. |
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
4a989d4
to
f1db1ca
Compare
f1db1ca
to
a0aa500
Compare
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
a0aa500
to
73032fe
Compare
No description provided.