Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Validate command not working as desired #278

Closed
Atharva-Shinde opened this issue Oct 17, 2022 · 10 comments
Closed

Validate command not working as desired #278

Atharva-Shinde opened this issue Oct 17, 2022 · 10 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Oct 17, 2022

Expected behaviour:
When a tweet within character-limit is created in an Issue, an automated PR from GitHub-action bot is created. Now if the author updates the Issue description with some new changes in the tweet, they should comment /validate to validate it again. If the tweet is within character limit, it will trigger the workflow and the bot will update the PR with the new tweet.

Current behaviour:
The tweet PR isn't getting updated with the new changes done by author in tweet description even though they use /validate command.

References to jobs:
Job Error: The process '/usr/bin/git' failed with exit code 1
https://github.com/kubernetes-sigs/contributor-tweets/actions/runs/3255451191/jobs/5344780842#step:6:515
https://github.com/kubernetes-sigs/contributor-tweets/actions/runs/2873883155/jobs/4561871980#step:6:515

@Atharva-Shinde
Copy link
Contributor Author

We could try updating GitHub actions(actions/checkout, actions/setup-node and twitter-together/action) and node of our workflow to the latest versions, as node 12 is deprecated and also the actions we are using in this workflow supports node 16. ref: actions/checkout#417

@imnmo
Copy link
Contributor

imnmo commented Oct 17, 2022

Thanks for the findings @Atharva-Shinde
To clarify: the job is failing due to a dependency error (latest node 12). Hence, the expected behavior for updating tweets is not happening?

@Atharva-Shinde
Copy link
Contributor Author

actions/checkout@v2 had some bugs with tokens and now with node 12 being deprecated, updating the workflow to latest versions can be a first step towards fixing the command if not being the only reason causing the failure of jobs :)
Also do refer to this comment I made while testing

@imnmo
Copy link
Contributor

imnmo commented Oct 17, 2022

I observed this strange behavior a while ago. Let's see with node upgrade things go better

@imnmo
Copy link
Contributor

imnmo commented Oct 21, 2022

@Atharva-Shinde #278 merge didn't solve the problem and I see new file changes after the merge. See here: https://github.com/kubernetes-sigs/contributor-tweets/pull/281/files

@Atharva-Shinde
Copy link
Contributor Author

@imnmo That is how workflow is supposed to perform and that's not where the problem is,
if you try to update the tweet issue with some new changes and /validate again, (in the working state) it should automatically update your pr with new changes, and this is where the error occurs (or was occurring).

So try changing your tweet issue and lets see if its working or is still broken

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2023
@imnmo
Copy link
Contributor

imnmo commented Feb 24, 2023

/close

see here #289

@k8s-ci-robot
Copy link
Contributor

@imnmo: Closing this issue.

In response to this:

/close

see here #289

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants