-
Notifications
You must be signed in to change notification settings - Fork 29
Validate command not working as desired #278
Comments
We could try updating GitHub actions(actions/checkout, actions/setup-node and twitter-together/action) and node of our workflow to the latest versions, as node 12 is deprecated and also the actions we are using in this workflow supports node 16. ref: actions/checkout#417 |
Thanks for the findings @Atharva-Shinde |
actions/checkout@v2 had some bugs with tokens and now with node 12 being deprecated, updating the workflow to latest versions can be a first step towards fixing the command if not being the only reason causing the failure of jobs :) |
I observed this strange behavior a while ago. Let's see with node upgrade things go better |
@Atharva-Shinde #278 merge didn't solve the problem and I see new file changes after the merge. See here: https://github.com/kubernetes-sigs/contributor-tweets/pull/281/files |
@imnmo That is how workflow is supposed to perform and that's not where the problem is, So try changing your tweet issue and lets see if its working or is still broken |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/close see here #289 |
@imnmo: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Expected behaviour:
When a tweet within character-limit is created in an Issue, an automated PR from GitHub-action bot is created. Now if the author updates the Issue description with some new changes in the tweet, they should comment
/validate
to validate it again. If the tweet is within character limit, it will trigger the workflow and the bot will update the PR with the new tweet.Current behaviour:
The tweet PR isn't getting updated with the new changes done by author in tweet description even though they use
/validate
command.References to jobs:
Job Error: The process '/usr/bin/git' failed with exit code 1
https://github.com/kubernetes-sigs/contributor-tweets/actions/runs/3255451191/jobs/5344780842#step:6:515
https://github.com/kubernetes-sigs/contributor-tweets/actions/runs/2873883155/jobs/4561871980#step:6:515
The text was updated successfully, but these errors were encountered: