Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Testing Validate Command after #273 merged #274

Closed
Atharva-Shinde opened this issue Oct 15, 2022 · 21 comments
Closed

Testing Validate Command after #273 merged #274

Atharva-Shinde opened this issue Oct 15, 2022 · 21 comments
Labels
kind/tweet Issues to parse and tweet from K8sContributor handle lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Oct 15, 2022

Provide the actual tweet content between the commented colons

This is a test TweetThis is a test Tweet

#274 (comment)

@Atharva-Shinde Atharva-Shinde added the kind/tweet Issues to parse and tweet from K8sContributor handle label Oct 15, 2022
@Atharva-Shinde
Copy link
Contributor Author

the job was skipped for some reason

@Atharva-Shinde
Copy link
Contributor Author

Atharva-Shinde commented Oct 15, 2022

/validate
EDIT: validating for This is a test Tweet

@github-actions
Copy link
Contributor

A new file has been created with your tweet content. Please refer the below linked PR

@Atharva-Shinde
Copy link
Contributor Author

worked! now with exceeding char limit tweet

@Atharva-Shinde
Copy link
Contributor Author

Atharva-Shinde commented Oct 15, 2022

/validate
EDIT: validating for
This is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test TweetThis is a test Tweet

@github-actions
Copy link
Contributor

Tweet content length is exceeding the permitted tweet length. Please rephrase the tweet and comment /validate to trigger the workflow again.

@Atharva-Shinde
Copy link
Contributor Author

great!
now changing back and validating

@Atharva-Shinde
Copy link
Contributor Author

/validate

@github-actions
Copy link
Contributor

A new file has been created with your tweet content. Please refer the below linked PR

@Atharva-Shinde
Copy link
Contributor Author

Atharva-Shinde commented Oct 15, 2022

/validate
EDIT: validating for This is a test TweetThis is a test Tweet

@github-actions
Copy link
Contributor

A new file has been created with your tweet content. Please refer the below linked PR

@Atharva-Shinde
Copy link
Contributor Author

Atharva-Shinde commented Oct 15, 2022

/validate
EDIT: validating again for This is a test TweetThis is a test Tweet

@github-actions
Copy link
Contributor

A new file has been created with your tweet content. Please refer the below linked PR

@Atharva-Shinde Atharva-Shinde changed the title Testing Validate Command [PLEASE IGNORE] Testing Validate Command [PLEASE IGNORE] after #273 merged Oct 15, 2022
@Atharva-Shinde Atharva-Shinde changed the title Testing Validate Command [PLEASE IGNORE] after #273 merged Testing Validate Command after #273 merged Oct 15, 2022
@Atharva-Shinde
Copy link
Contributor Author

I cross-checked on my fork and wanted to re-surface it here.

  1. With Fix Validate command #273 merged, now a tweet PR isn't automatically generated unless we /validate on an issue
  2. It's still not working as expected on this repo.
  3. But is totally working on my fork. Always.
    ref: with changes of #273:- here
    without changes of #273:- here

@chris-short
Copy link
Contributor

@Atharva-Shinde We should probably setup some time to look into this together. More eyes are better usually. With KubeCon upon us, this week and next are pretty much toast (unless you're going to be in town).

@Atharva-Shinde
Copy link
Contributor Author

I Agree @chris-short ! Just wanted to get the ball rolling as it's been hanging around for a long time now. IMO this Issue could be the test issue to test our workflow so that there's no need to wait for creating new tweet issue every time we want to test the workflow. I've also setup an issue so that we can keep track of this in one place.
Although I'm in full support of closing this issue if it's just getting redundant by time and isn't adding any value.

Feedbacks welcome :)

@imnmo
Copy link
Contributor

imnmo commented Oct 21, 2022

@chris-short @Atharva-Shinde this merge didn't solve the problem and I see new file changes after the merge. See here: https://github.com/kubernetes-sigs/contributor-tweets/pull/281/files

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2023
@imnmo
Copy link
Contributor

imnmo commented Feb 24, 2023

/close

see here #289

@k8s-ci-robot
Copy link
Contributor

@imnmo: Closing this issue.

In response to this:

/close

see here #289

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/tweet Issues to parse and tweet from K8sContributor handle lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants