Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml #9010

Merged
merged 2 commits into from
Mar 23, 2023
Merged

chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml #9010

merged 2 commits into from
Mar 23, 2023

Conversation

Juneezee
Copy link
Contributor

Description of your changes:

The package github.com/ghodss/yaml is no longer actively maintained. See discussion in ghodss/yaml#75 and ghodss/yaml#80. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml. It is actively maintained by Kubernetes SIG, and also widely used in K8s projects.

The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.

Checklist:

@google-oss-prow
Copy link

Hi @Juneezee. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Linchin
Copy link
Contributor

Linchin commented Mar 20, 2023

/ok-to-test

@Linchin
Copy link
Contributor

Linchin commented Mar 21, 2023

Hi @Juneezee, thank you so much for your contribution! Just added the / ok-to-test label. It looks like you also need to update the license file.

@Juneezee
Copy link
Contributor Author

/retest

2 similar comments
@Juneezee
Copy link
Contributor Author

/retest

@Juneezee
Copy link
Contributor Author

/retest

@Linchin
Copy link
Contributor

Linchin commented Mar 22, 2023

Hi @Juneezee, there is still something wrong with the integration test. Could you please fix this too? Thank you.

@Juneezee
Copy link
Contributor Author

Hi @Linchin. Correct me if I'm wrong, but I've looked at the logs and I don't think the failure is caused by this PR.

@Juneezee
Copy link
Contributor Author

@Linchin The error comes from [email protected] which was released 4 days ago (https://github.com/RebeccaStevens/deepmerge-ts/releases/tag/v5.0.0) and dropped support for Node 14.

�[36mintegration-test-sdwcd-2311914601: npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=16.0.0"} (current: {"node":"14.21.2","npm":"6.14.17"})�[0m
�[36mintegration-test-sdwcd-2311914601: npm WARN notsup Not compatible with your version of node/npm: [email protected]�[0m

�[36mintegration-test-sdwcd-2311914601: > [email protected] test /src�[0m
�[36mintegration-test-sdwcd-2311914601: > wdio wdio.conf.js�[0m
�[36mintegration-test-sdwcd-2311914601: �[0m
�[36mintegration-test-sdwcd-2311914601: (node:182) UnhandledPromiseRejectionWarning: TypeError: Object.hasOwn is not a function�[0m
�[36mintegration-test-sdwcd-2311914601:     at file:///src/node_modules/deepmerge-ts/dist/node/index.mjs:240:51�[0m
�[36mintegration-test-sdwcd-2311914601:     at Array.filter (<anonymous>)�[0m
�[36mintegration-test-sdwcd-2311914601:     at getUtils (file:///src/node_modules/deepmerge-ts/dist/node/index.mjs:240:18)�[0m
�[36mintegration-test-sdwcd-2311914601:     at deepmergeCustom (file:///src/node_modules/deepmerge-ts/dist/node/index.mjs:220:19)�[0m
�[36mintegration-test-sdwcd-2311914601:     at file:///src/node_modules/webdriver/build/utils.js:10:19�[0m
�[36mintegration-test-sdwcd-2311914601:     at <anonymous> (<anonymous>)�[0m

Object.hasOwn is only available after V8 v9.3 1. That means only Node.js 16 and above supports it 2

Footnotes

  1. https://v8.dev/features/object-has-own ↩

  2. https://nodejs.org/en/download/releases ↩

@Linchin
Copy link
Contributor

Linchin commented Mar 22, 2023

Hi @Linchin. Correct me if I'm wrong, but I've looked at the logs and I don't think the failure is caused by this PR.

I think you are right. @chensun created a PR today to fix this issue.

@Linchin
Copy link
Contributor

Linchin commented Mar 22, 2023

/test kubeflow-pipeline-e2e-test

@Juneezee
chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml
2e003b1 
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee
Update licenses CSV
4373a7a 
Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee
Copy link
Contributor Author

/retest

@Juneezee
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

7 similar comments
@Juneezee
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

@Juneezee
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

@Juneezee
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

@Juneezee
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

@Juneezee
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

@Juneezee
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

@Juneezee
Copy link
Contributor Author

/test kubeflow-pipelines-samples-v2

chensun
chensun reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 23, 2023
@Linchin
Copy link
Contributor

Linchin commented Mar 23, 2023

/approve

1 similar comment
@chensun
Copy link
Member

chensun commented Mar 23, 2023

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, Linchin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2f64e37 into kubeflow:master Mar 23, 2023
rd-pong pushed a commit to rd-pong/pipelines that referenced this pull request Apr 26, 2023
@Juneezee @rd-pong
chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (kube…
33ff92e 
…flow#9010)

* chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml`

At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <[email protected]>

* Update licenses CSV

Signed-off-by: Eng Zer Jun <[email protected]>

---------

Signed-off-by: Eng Zer Jun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun left review comments

@Linchin Linchin Awaiting requested review from Linchin

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Juneezee @Linchin @chensun