Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling BPFLSM based KSP protection on Kubearmor itself #1831

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Enabling BPFLSM based KSP protection on Kubearmor itself #1831

merged 5 commits into from
Nov 5, 2024

Conversation

daemon1024
Copy link
Member

@daemon1024 daemon1024 commented Aug 7, 2024 •
edited
Loading

Purpose of PR?:

Succeeds #1717
Fixes #1688

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@daemon1024 daemon1024 marked this pull request as ready for review October 15, 2024 15:34
rksharma95
rksharma95 previously approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@rksharma95 rksharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Aryan-sharma11
Aryan-sharma11 requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Aryan-sharma11 Aryan-sharma11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use filepath.Join() to build paths.

KubeArmor/core/containerdHandler.go Outdated Show resolved Hide resolved
KubeArmor/core/containerdHandler.go Outdated Show resolved Hide resolved
KubeArmor/core/crioHandler.go Outdated Show resolved Hide resolved
KubeArmor/core/crioHandler.go Outdated Show resolved Hide resolved
KubeArmor/core/dockerHandler.go Outdated Show resolved Hide resolved
@daemon1024 daemon1024 mentioned this pull request Oct 28, 2024
Closed
7 tasks
rootxrishabh
rootxrishabh approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@rootxrishabh rootxrishabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Aryan-sharma11 Aryan-sharma11 merged commit 3574106 into kubearmor:main Nov 5, 2024
19 checks passed
@DelusionalOptimist DelusionalOptimist mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootxrishabh rootxrishabh rootxrishabh approved these changes

@Aryan-sharma11 Aryan-sharma11 Aryan-sharma11 approved these changes

@rksharma95 rksharma95 rksharma95 left review comments

@DelusionalOptimist DelusionalOptimist Awaiting requested review from DelusionalOptimist

@Prateeknandle Prateeknandle Awaiting requested review from Prateeknandle

@PrimalPimmy PrimalPimmy Awaiting requested review from PrimalPimmy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mount procfs instead of using hostpid
4 participants
@daemon1024 @Aryan-sharma11 @rootxrishabh @rksharma95