Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation of Container Metric Data #1364

Open
wants to merge 5 commits into
base: mvp_demo
Choose a base branch
from

Conversation

shreyabiradar07
Copy link
Contributor

@shreyabiradar07 shreyabiradar07 commented Nov 11, 2024

Description

This PR has the following changes:

  • Aggregates the metric data and calculates the avg, min, max values based on the container experiment to generate recommendations
  • The data comes from the individual queries in local monitoring mode PR 1359

Steps to generate recommendations for container and namespace openshift-apiserver- https://privatebin.corp.redhat.com/?7ed7bfc48564d285#fpUsX7rhx2c6fL5HufqdJCRQJsQpMzs32HYb8aKA7Jc

After generating recommendations, either of the below steps can be followed to verify the aggregation of individual query data

  1. Using kruize pod logs
  • Input CSV file with metric data for each pod is logged under - Contents of input.csv:
  • Aggregated Output CSV file is logged under - Contents of output.csv:
  1. Using kubectl exec to access CSV files inside the pod
  • Exec into Kruize pod:
    kubectl exec -it <kruize-pod> -n openshift-tuning -- /bin/bash
  • pwd
    /home/autotune/app
  • ls
    input.csv jre output output.csv target

NOTE: PR currently has added logs for verifying the aggregation of data, once reviewed will be removed before merging

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on: ResourceHub, Openshift

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

docker image: quay.io/shbirada/metric_data_aggr:v1

@shreyabiradar07 shreyabiradar07 self-assigned this Nov 11, 2024
@shreyabiradar07 shreyabiradar07 added this to the Kruize 0.2 Release milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recommendation
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants