-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix composite type declaration with a "type" composite fragment #484
Conversation
…ther type (enum, for example)
Hi @kfirba, thank you for the contribution! There are some linter errors, if you fix those I will merge it :-) |
@kristiandupont The linting issues are not from the change I made, they are there in |
Ah, then perhaps it's because I updated some dependencies recently. CI should have caught that but I tend to merge many at a time so sometimes things slip through.. |
Indeed the problem is on |
@kristiandupont Great :) |
Try now! |
@kristiandupont Should be good now :) |
Merged and published. Thank you for contributing, nice find! |
Thanks for the package! |
Hey.
I have a pivot table with a composite key, where a fragment of the primary key is an enum:
Without this PR, there's a faulty generated type for this table:
It happens since the
getIdentifierDeclaration
function has no awareness of other non-composite types.This PR falls back to inspect the
nonCompositeTypeImports
object in case the composite type is not part of the built-in type mappings.The result now is: