Update pg-query-emscripten to 5.1.0 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin-nemcev
commented
Nov 15, 2024
| let pgQueryInstance: any; | ||
| const getPgQuery = async () => { | ||
| if (!pgQueryInstance) { | ||
| const { default: pgQueryModule } = await import( |
There was a problem hiding this comment.
New emscripten version requires async initialisation. Since project target didn't support top-level await, and because view parsing is not always required, I made both importing and initialisation happen on-demand
valentin-nemcev
commented
Nov 15, 2024
| @@ -65,12 +75,13 @@ function parseSelectStmt( | |||
|
|
|||
| return viewReferences; | |||
| } | |||
| function parseViewDefinition( | |||
| async function parseViewDefinition( | |||
There was a problem hiding this comment.
It's called from extractView, which already was async and used await
|
Very nice, thank you for contributing! 🙏 |
|
Now published. As is Kanel and Schemalint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg-query-emscriptenhas a very annoying bug where it prints it's source code on exception. This PR updatespg-query-emscriptento the latest version and fixes incompatibilities with the new version.