Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add cancel context to NewGRPCClient #720

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Add cancel context to NewGRPCClient #720

wants to merge 1 commit into from

Conversation

kthatipally
Copy link
Contributor

PR Summary

Bug fix to address the issue of java-external-provider.exe not ending after analysis completion.
Introduces a cancel context to the NewGRPCClient to ensure proper termination of the gRPC client.

  • provider/grpc/provider.go: Added context.WithCancel to manage the lifecycle of the gRPC client and ensure it can be properly stopped.
  • provider/grpc/provider.go: Updated grpcProvider struct to include cancelCmd and invoked cancelCmd() in the Stop method to terminate the context.

@kthatipally kthatipally changed the title Add cancel context to NewGRPCClient 🐛 Add cancel context to NewGRPCClient Nov 13, 2024
@kthatipally kthatipally changed the title 🐛 Add cancel context to NewGRPCClient 🐛 Add cancel context to NewGRPCClient Nov 13, 2024
@eemcmullan
Copy link
Contributor

@kthatipally LGTM, thanks! Just needs sign-off

@kthatipally kthatipally force-pushed the kthatipally/add-cancel-context-grpc branch from 99dc02a to 1422af9 Compare November 22, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemcmullan eemcmullan eemcmullan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kthatipally @eemcmullan