fixed issue where if enum name starts with letter I it gets cut off f… #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom name in generated interface
|
Hey @kondi, I ran across an issue, where typings are incorrect when enum starts with letter "I" (eg. enum named "Iterable" changes into "terable", so I had to fix it for my personal use. What do You think of this? Can You tell if there is a risk of issues with this solution? It looks rather clunky, I didn't mess around a lot with refactoring, because I wanted to make the change as backwards compatible as I can. the only negative consequence that I meet with is a little bit longer generation time (because there are two loops through ast instead of one) |
|
(I can add enum into example file that is tested if You think it will add value to tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rom name in generated interface