fix python regex test scripts #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python, when you pass an array to "call", the arguments are not to be quoted unless you are intending on passing the quotes to the underlying command you are running. In this case the the underlying programs test_rand.c and test_rand_neg.c are not expecting their arguments to be quoted, but instead, are expecting them to be unquoted regular expression strings. This is a common mistake because people confuse the BASH syntax for escaping characters with the strings passed to a subprocess in Python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike a BASH shell command, in python, when you pass an array of strings to
call, the arguments are not to be quoted unless the intention is to pass the quotes to the underlying command. In this case the the underlying programs "test_rand.c" and "test_rand_neg.c" which are not expecting their arguments to be quoted, but instead, are expecting them to be unquoted regular expression strings. This is a common mistake because BASH requires quotes to disable special character but Python does no escaping, it just passes the string unmodified to the new subprocess.