simplify matchplus and matchstar #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`matchplus` can be simplified by only modifying `matchlength` once the complete match is successful. This means it doesn't have to rewind `matchlength` as it iterates through each possible `matchpattern`. This also means it keeps `matchlength` unmodified if it doesn't return a match. Because of this last part, this also means that `matchstar` can leverage `matchplus` which reduces it to single line of code `return matchplus(...) || matchpattern(..)`.
marler8997
force-pushed
the
simplifyStarAndPlus
branch
from
e5cf41c
to
d0c52ea
Compare
|
Very interestingly, this change has noticeably improved performance. Before this change, running After this change I'm consistently getting below 3.6: The run times are much more consistent and it's around a 25% improvement for that test. My guess is that this performance may be due to less code needed to be swapped in and out of the icache? Not sure, but interesting. |
rurban
approved these changes
Jun 20, 2022
matyalatte
added a commit
to matyalatte/tiny-str-match
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchpluscan be simplified by only modifyingmatchlengthonce the complete match is successful. This means it doesn't have to rewindmatchlengthas it iterates through each possiblematchpattern. This also means it keepsmatchlengthunmodified if it doesn't return a match. Because of this last part, this also means thatmatchstarcan leveragematchpluswhich reduces it to single line of codereturn matchplus(...) || matchpattern(..).