Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projectHistoryLogs): record logs for transfering ownership TASK-944 #5313

Draft
wants to merge 4 commits into
base: rsgraber/TASK-944-cloned-perms
Choose a base branch
from

Conversation

rgraber
Copy link
Contributor

@rgraber rgraber commented Dec 2, 2024

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Record project history logs for project ownership transfers.

👀 Preview steps

Feature/no-change template:

  1. ℹ️ Have at least 2 users and a project
  2. Go to Project > Settings > Sharing
  3. Transfer ownership to user2
  4. Go to http://localhost/api/v2/audit-logs/?q=log_type:project-history AND metadata__asset_uid:<asset_uid>&format=json
  5. 🟢 There should be a new log with action="transfer" and the usual metadata, plus an additional metadata.username = "user2" field

💭 Notes

This does not rely on the transfer being successful/accepted. We want to log any attempt to transfer. Canceled requests will be handled in v2.

@rgraber rgraber changed the title feat(projectHistoryLogs): record logs for transfering ownership feat(projectHistoryLogs): record logs for transfering ownership TASK-944 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant