Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(darker): improve comparison refs for focused errors #5311

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p2edwards
Copy link
Contributor

@p2edwards p2edwards commented Dec 2, 2024

πŸ‘€ Preview steps

  1. πŸ”΄ run darker on a branch with an old base ref.
  2. 🟒 after this fix
  3. 🟒 edit tasks.py to break a flake8 rule

Screenshots from test commits in #5295

  1. πŸ”΄πŸ–ΌοΈ unrelated files linted
  2. πŸŸ’πŸ–ΌοΈ no unrelated files linted
  3. πŸŸ’πŸ–ΌοΈ related file(s) linted

πŸ’­ Notes

Change which commits we compare in darker.yml so that their diffs don't include changes introduced by other branches.

More detailed explanation here

xref internal chat

@p2edwards p2edwards changed the title ci(darker): compare ci(darker): improve comparison refs for focused errors Dec 2, 2024
@p2edwards p2edwards added workflow Related to development process Back end labels Dec 2, 2024
@p2edwards p2edwards marked this pull request as ready for review December 2, 2024 16:42
@p2edwards p2edwards requested review from rgraber and removed request for bufke, jnm, magicznyleszek and noliveleger December 2, 2024 16:42
Base automatically changed from phil/ci-paths-filter to main December 2, 2024 17:31
An error occurred while trying to automatically change base from phil/ci-paths-filter to main December 2, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back end workflow Related to development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant