feat(organizations): update is_mmo to identify mmo subscriptions TASK-1231 #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st, adjust existing tests
jamesrkiger
commented
Nov 21, 2024
jamesrkiger
commented
Nov 21, 2024
noliveleger
requested changes
Nov 25, 2024
Comment on lines
+182
to
+189
| if self.mmo_override: | ||
| return True | ||
|
|
||
| if billing_details := self.active_subscription_billing_details(): | ||
| if product_metadata := billing_details.get('product_metadata'): | ||
| return product_metadata.get('mmo_enabled') == 'true' | ||
|
|
||
| return False |
There was a problem hiding this comment.
@jamesrkiger we may change the docstring then ;-)
There was a problem hiding this comment.
Good catch. I have updated the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Summary
Change the logic of the
is_mmoproperty on the Organization model to check Stripe product metadata for the'mmo_enabled'field.👀 Preview steps
This change is covered by a unit test.
For a manual test:
is_mmoproperty in shell. Onmain, this will beTruebecause it is only checking to see whether or not an org has a plan. On this branch, however, it will correctly beFalsebecause storage addons shouldn't enable MMO features.is_mmoproperty in shell. On this branch, it should now beTrue.