feat(organizations): hide organization fields from settings for mmo organizations - TASK-978

[pauloamorimbr]

🗒️ Checklist

1. run linter locally
2. update all related docs (API, README, inline, etc.), if any
3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
4. tag PR: at least frontend or backend unless it's global
5. fill in the template below and delete template comments
6. review thyself: read the diff and repro the preview as written
7. open PR & confirm that CI passes
8. request reviewers, if needed
9. delete this section before merging

📣 Summary

Organization fields are not displayed anymore in setting screens for MMOs.

👀 Preview steps

Feature/no-change template:

1. ℹ️ have account
2. Go to "settings" view at /#/account/settings
3. Use the feature flag ?ff_mmoEnabled=true
4. Set the organization as MMO
5. 🟢 Fields should not be displayed
6. Set the feature flag to false as in ?ff_mmoEnabled=false
7. 🟢 Fields should be displayed again

💭 Notes

The 'organization', 'organization_type' and 'organization_website' are now being hidden when the current organization has the is_mmo flag.

[jamesrkiger]

Did this get added on accident? Looks unused.

[jamesrkiger]

Since we're touching this section, I have to ask: Do we need these session store readiness checks? My impression is we could just use 'email' in currentAccount (which I suspect is our way of making sure the store has a real user and not an anonymous user stub).

[jamesrkiger]

@pauloamorimbr This isn't an issue with your code, but I am concerned about the way we are submitting the PATCH request in this form. It looks to me like we are basically just always sending the data for every form field. It's a PATCH request but we're essentially treating it like a PUT. This gets uglier as a result of the changes we are making here: Now we are submitting the org detail fields even though we aren't displaying them.

At the very least, I believe we need to stop submitting org data this way. If it didn't take too long, I would say it would be better if we only submitted data for "dirty" form fields (ones that have been edited by the user). But if that second goal is going to take too long perhaps we can ignore that for the moment. Can you spend 20 minutes or so to determine what the best approach is here?

[pauloamorimbr]

@pauloamorimbr This isn't an issue with your code, but I am concerned about the way we are submitting the PATCH request in this form. It looks to me like we are basically just always sending the data for every form field. It's a PATCH request but we're essentially treating it like a PUT. This gets uglier as a result of the changes we are making here: Now we are submitting the org detail fields even though we aren't displaying them.

At the very least, I believe we need to stop submitting org data this way. If it didn't take too long, I would say it would be better if we only submitted data for "dirty" form fields (ones that have been edited by the user). But if that second goal is going to take too long perhaps we can ignore that for the moment. Can you spend 20 minutes or so to determine what the best approach is here?

After the refactors in #5303 and #5290, I'm back here. Now this behaves the proper way, like you commented, sending only the edited fields to the PATCH call, thus not sending organization data when the organization is MMO since the fields are not visible for editing.