Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 17.0 staging branch #227

Merged
merged 7 commits into from
Aug 14, 2024
Merged

feat: 17.0 staging branch #227

merged 7 commits into from
Aug 14, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Oct 10, 2023 •
edited
Loading

  1. Update to using kmc 17.0.328 to build lexical models
  2. Standardize formatting and copyright string in LICENSE.md files
  3. Include LICENSE.md in each .kps

@mcdurdin
chore: format LICENSE.md consistently
41a5282 
Ensures that LICENSE.md includes the word 'Copyright' in the second
clause to meet the validation requirements in kmc.

Adds LICENSE.md to nrc.str.sencoten, where it was inexplicably missing.
@mcdurdin
chore: add LICENSE.md to package
267c9ab 
This is required to meet the updated kmc requirements in 17.0.
@mcdurdin
Merge pull request #225 from keymanapp/chore/add-license-to-packages
460c225 
chore: add LICENSE.md to package and format consistently.
@mcdurdin mcdurdin added this to the A17S23 milestone Oct 10, 2023
@mcdurdin mcdurdin added the feat label Oct 10, 2023
@mcdurdin mcdurdin self-assigned this Oct 10, 2023
@mcdurdin mcdurdin modified the milestones: A17S23, A17S24 Oct 15, 2023
@mcdurdin mcdurdin modified the milestones: A17S24, A17S25 Oct 27, 2023
@mcdurdin mcdurdin modified the milestones: A17S25, A17S26 Nov 13, 2023
@mcdurdin mcdurdin modified the milestones: A17S26, A17S27 Nov 27, 2023
@mcdurdin mcdurdin modified the milestones: A17S27, A17S28 Dec 8, 2023
@mcdurdin mcdurdin modified the milestones: A17S28, A17S29 Dec 30, 2023
@mcdurdin mcdurdin modified the milestones: A17S29, A17S30 Jan 6, 2024
@mcdurdin mcdurdin modified the milestones: A17S30, A17S31 Jan 20, 2024
@mcdurdin mcdurdin modified the milestones: A17S31, B17S1 Feb 3, 2024
@mcdurdin mcdurdin modified the milestones: B17S1, B17S2 Feb 17, 2024
@mcdurdin mcdurdin modified the milestones: B17S2, B17S3 Mar 3, 2024
@darcywong00 darcywong00 modified the milestones: B17S3, B17S4 Mar 16, 2024
@darcywong00 darcywong00 added this to the A18S1 milestone Apr 28, 2024
@darcywong00 darcywong00 modified the milestones: A18S1, A18S2 May 11, 2024
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3 May 24, 2024
@darcywong00 darcywong00 mentioned this pull request May 30, 2024
Closed
@mcdurdin mcdurdin modified the milestones: A18S3, A18S4 Jun 7, 2024
@darcywong00 darcywong00 modified the milestones: A18S4, A18S5 Jun 21, 2024
@jahorton
Copy link
Contributor

Eagerly awaiting this, in part because there's at least one bug fix landing in 17.0's compiler that will be relevant for future work.

Fix: keymanapp/keyman#11074
Future work: keymanapp/keyman#11876

@darcywong00 darcywong00 modified the milestones: A18S5, A18S6 Jul 5, 2024
@darcywong00 darcywong00 modified the milestones: A18S6, A18S7 Jul 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@mcdurdin mcdurdin marked this pull request as ready for review August 12, 2024 04:19
darcywong00
darcywong00 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

In the keyboards repo, the .keyboard_info descriptions were moved to the .kps files.
Is kmc handling .model_info files differently?

@mcdurdin mcdurdin mentioned this pull request Aug 14, 2024
Closed
@mcdurdin
Copy link
Member Author

In the keyboards repo, the .keyboard_info descriptions were moved to the .kps files.
Is kmc handling .model_info files differently?

This is not yet implemented -- now tracking this in keymanapp/keyman#12184

@mcdurdin mcdurdin merged commit 56a11b0 into master Aug 14, 2024
2 checks passed
@mcdurdin mcdurdin deleted the staging-17.0 branch August 14, 2024 11:52
This was referenced Aug 16, 2024
Closed
Closed
@darcywong00 darcywong00 mentioned this pull request Aug 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcywong00 darcywong00 darcywong00 approved these changes

Assignees

@mcdurdin mcdurdin

Labels
feat
Projects
None yet
Milestone
A18S8
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdurdin @jahorton @darcywong00