feat(developer): support building .keyboard_info without source version 🎺 #9474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #9351. Adds support for building a .keyboard_info file without having source .keyboard_info file: * Constructs a default source .keyboard_info in memory * Hints if license is missing * If LICENSE.md is present, verifies it matches the MIT license text * Adds project option to turn on or off metadata generation. This will default to False for version 1.0 projects, and to True for version 2.0 projects. This means that the keyboard repository will need a PR to enable metadata generation for existing projects in the repository, but this is important to avoid breaking builds for existing projects that are not in the repository. * Turns on additional c8 coverage for kmc projects
Also fixes a file reference issue in kmpJson.options, where paths were stripped too early in the process. Removes a now-irrelevant unit test for keyboard_info. TODO: markdown to html during the keyboard_info build.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
feat
labels
86 tasks
darcywong00
reviewed
Aug 17, 2023
darcywong00
reviewed
Aug 17, 2023
darcywong00
reviewed
Aug 17, 2023
1 task
Base automatically changed from
chore/developer/keyboard-info-font-examples-cleanup
to
epic/package-metadata
September 1, 2023 03:05
mcdurdin
deleted the
feat/developer/compile-without-source-keyboard-info
branch
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #9351.
Adds support for building a .keyboard_info file without having source .keyboard_info file:
TODO:
@keymanapp-test-bot skip