Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2303_missing_js] Update some of the keyboards in this issue #2308

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

LornaSIL
Copy link
Contributor

Partially addresses #2303

@mcdurdin I did not address:

gff_amh_7.kps
gff_amh_powerpack_7.kps
gff_ethiopic_7.kps

because those are deprecated.
How do you want that handled? Or maybe you should not be testing deprecated keyboards?

@dyacob
Copy link
Contributor

dyacob commented Jul 19, 2023

Did Keyman 7 produce JS files? I think it only created desktop keyboards, no web or mobile. So they may not really be "missing" in a sense. The packages were just not maintained to target platforms that came later -which in turn is handled by the successor projects that deprecate these.

@LornaSIL LornaSIL changed the title [2303_missing_js] Update some of the keyboars in this issue [2303_missing_js] Update some of the keyboards in this issue Jul 19, 2023
@LornaSIL LornaSIL merged commit ca4b1ec into keymanapp:master Jul 19, 2023
@LornaSIL LornaSIL deleted the 2303_missing_js branch July 19, 2023 21:01
@mcdurdin
Copy link
Member

Did Keyman 7 produce JS files? I think it only created desktop keyboards, no web or mobile. So they may not really be "missing" in a sense. The packages were just not maintained to target platforms that came later -which in turn is handled by the successor projects that deprecate these.

The reason these keyboards were flagged is because their &TARGETS system store included mobile, e.g.:

store(&TARGETS) 'any windows'

@mcdurdin
Copy link
Member

mcdurdin commented Jul 21, 2023

I note that gff_gurage_and_amharic has an override for platformsupport in its keyboard_info:

"platformSupport": {
"windows": "full",
"macos": "full",
"linux": "full"
}

This means it still won't be offered on touch platforms

@dyacob
Copy link
Contributor

dyacob commented Jul 21, 2023

This was the original intent, that it be desktop only. GFF Gurage does have a touch layout, but it really only works in the Keyman App at this time since the Android and Apple system fonts do not yet support the Gurage letters added to Unicode 14. The KM app can load its own font. Android 14 should finally include a Noto Ethiopic font update with the 28 extra letters. Apple is still dragging its feet.

So the override would eventually be removed. Can platformSupport include a minimal version of Android or iOS? A way to specify Android >= 14 , iOS >= 18.3 would be helpful when the system font updates arrive.

Checking the .keyboard_info 1.0 Specification there doesn't appear to be support for this, but it would be good to add to the KeyboardPlatformInfo object at some point.

@DavidLRowe
Copy link
Contributor

@dyacob @mcdurdin Does any of this discussion need to be moved to a new issue so that it can be acted upon?

@mcdurdin
Copy link
Member

@dyacob @mcdurdin Does any of this discussion need to be moved to a new issue so that it can be acted upon?

I think it's all good now. There's a follow-up, related, issue regarding .keyboard_info files and inconsistent platform support data that may illuminate a little in #2311.

@mcdurdin
Copy link
Member

Can platformSupport include a minimal version of Android or iOS? A way to specify Android >= 14 , iOS >= 18.3 would be helpful when the system font updates arrive.

Checking the .keyboard_info 1.0 Specification there doesn't appear to be support for this, but it would be good to add to the KeyboardPlatformInfo object at some point.

This would be a "nice to have" which I will track in work around the package metadata formats in keymanapp/keyman#9351. No promises at this point! I will note that it's actually really hard to maintain this level of version metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants