-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2303_missing_js] Update some of the keyboards in this issue #2308
Conversation
Did Keyman 7 produce JS files? I think it only created desktop keyboards, no web or mobile. So they may not really be "missing" in a sense. The packages were just not maintained to target platforms that came later -which in turn is handled by the successor projects that deprecate these. |
The reason these keyboards were flagged is because their
|
I note that gff_gurage_and_amharic has an override for platformsupport in its keyboard_info: keyboards/release/packages/gff_gurage_and_amharic/gff_gurage_and_amharic.keyboard_info Lines 28 to 32 in 59c44e8
This means it still won't be offered on touch platforms |
This was the original intent, that it be desktop only. GFF Gurage does have a touch layout, but it really only works in the Keyman App at this time since the Android and Apple system fonts do not yet support the Gurage letters added to Unicode 14. The KM app can load its own font. Android 14 should finally include a Noto Ethiopic font update with the 28 extra letters. Apple is still dragging its feet. So the override would eventually be removed. Can Checking the .keyboard_info 1.0 Specification there doesn't appear to be support for this, but it would be good to add to the |
This would be a "nice to have" which I will track in work around the package metadata formats in keymanapp/keyman#9351. No promises at this point! I will note that it's actually really hard to maintain this level of version metadata. |
Partially addresses #2303
@mcdurdin I did not address:
because those are deprecated.
How do you want that handled? Or maybe you should not be testing deprecated keyboards?