Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@kampus/sozluk-content): add tags as new terms #591

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

igdiaysu
Copy link
Member

@igdiaysu igdiaysu commented Aug 2, 2023

If the tags of the existing files were not available as files, they were created as [sozluk-term].mdx files. And tags were added to the new files.

@igdiaysu igdiaysu self-assigned this Aug 2, 2023
@igdiaysu igdiaysu requested a review from a team as a code owner August 2, 2023 11:27
@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
kampus-ui ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 8:41pm

@vercel
Copy link

vercel bot commented Aug 2, 2023

@igdiaysu is attempting to deploy a commit to the kamp-us Team on Vercel.

A member of the Team first needs to authorize it.

@@ -0,0 +1,8 @@
---
title:
Copy link
Member

@rasitds rasitds Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title is missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resim

@@ -0,0 +1,7 @@
---
title:
Copy link
Member

@rasitds rasitds Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title is missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resim

@igdiaysu igdiaysu requested review from rasitds and removed request for rasitds August 2, 2023 14:45
@igdiaysu igdiaysu changed the title feat(@kampus/sozluk-content): add tags as empty *.mdx files and linked tags added to the new files feat(@kampus/sozluk-content): add tags as empty *.mdx files and linked tags added to the all files Aug 2, 2023
@igdiaysu igdiaysu changed the title feat(@kampus/sozluk-content): add tags as empty *.mdx files and linked tags added to the all files feat(@kampus/sozluk-content): add wiki-link tags to the all files and add new terms Aug 2, 2023
@usirin
Copy link
Member

usirin commented Aug 3, 2023

Hello @igdiaysu 👋 TY so much for this work.

Did we have a discussion about putting wikilinks onto tags before? Tags are already easily parseable since it's in frontmatter part of the markdown, whereas wikilinks should ideally be used in the content itself.

I like having them linked through anyway though, so i don't think we should close this PR. But i think we can move them to the bottom of the text and list them as related content:

---
title: something
tags:
- foo
- bar
---

## Bağlantılar
- [[related-sozluk-term|Related sozluk term]]
- [[related-sozluk-term2|Related sozluk term2]]

@igdiaysu igdiaysu marked this pull request as draft August 3, 2023 19:50
@igdiaysu igdiaysu changed the title feat(@kampus/sozluk-content): add wiki-link tags to the all files and add new terms feat(@kampus/sozluk-content): add tags as new terms Aug 3, 2023
@igdiaysu igdiaysu requested a review from Ketcap August 3, 2023 20:47
@Ketcap Ketcap marked this pull request as ready for review August 4, 2023 08:39
@Ketcap Ketcap merged commit 62733d1 into kamp-us:dev Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants