Connect pano to GQL #572
Merged
Connect pano to GQL #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Ketcap
reviewed
Jul 30, 2023
Ketcap
reviewed
Jul 30, 2023
usirin
force-pushed
the
pano-gql-connection
branch
from
f78cb4a
to
a572cf4
Compare
usirin
force-pushed
the
pano-gql-connection
branch
from
1a87969
to
d375fe4
Compare
Ketcap
reviewed
Aug 1, 2023
usirin
force-pushed
the
pano-gql-connection
branch
from
d375fe4
to
5851858
Compare
usirin
force-pushed
the
pano-gql-connection
branch
from
c7fa2b2
to
84ea280
Compare
usirin
added
ready for review
usirin
force-pushed
the
pano-gql-connection
branch
from
84ea280
to
71e0ecb
Compare
usirin
commented
Aug 4, 2023
| const IS_SERVER = typeof window === typeof undefined; | ||
| const CACHE_TTL = 5 * 1000; // 5 seconds, to resolve preloaded results | ||
|
|
||
| const HTTP_ENDPOINT = IS_SERVER ? (process.env.NEXT_PUBLIC_GQL_URL as string) : "/gql"; |
There was a problem hiding this comment.
This line requires apps using this package to have a rewrite rule configured for /gql url to real graphql url (eg https://gql.dev.kamp.us/graphql)
|
Merging this to unblock stuff, we can open bug tickets if we see something broken. |
Makes sense tbh! Sounds awesome, can't wait to develop all the features with GQL/relay 🤌🏻😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects pano to GQL.
Closes #544
Closes #545
Closes #582
Closes #588
Closes #589
Closes #590