Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated launch-tree from Help Menu Option to View #7113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jayeshsingh9767
Copy link
Contributor

Migrated Menu Option of Launch Jupyter Notebook File Browser from Help Menu Option to View.
closes #7004

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jayeshsingh9767/notebook/issue_7004

@jtpio
Copy link
Member

jtpio commented Oct 27, 2023

Thanks @jayeshsingh9767 for looking into this.

I think it was originally left in the Help menu because this is where the item for launching the classic notebook used to be placed in JupyterLab. So it was left there to make sure users would still be able to find a way to go to the Notebook application.

@jayeshsingh9767
Copy link
Contributor Author

@jtpio if this is not an issue, Should I close this PR?

@jtpio
Copy link
Member

jtpio commented Oct 27, 2023

Maybe we can ping @lahwaacz who opened #7004 for awareness first.

@jayeshsingh9767
Copy link
Contributor Author

@lahwaacz could you please help here?

@lahwaacz
Copy link

I think it was originally left in the Help menu because this is where the item for launching the classic notebook used to be placed in JupyterLab. So it was left there to make sure users would still be able to find a way to go to the Notebook application.

I think having one button in the View menu and another one in the Help menu is not intuitive for new users who never used the button for launching the classic notebook. Or for old users who already forgot where it was... JupyterLab should focus on having intuitive interface in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move button to switch from JupyterLab to Notebook
3 participants