Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CourseDir.student_id_exclude option to exclude students #1179

Merged
merged 3 commits into from
Aug 24, 2019

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Aug 19, 2019

This adds a --CourseDirectory.student_id_exclude which can exclude the given students from autograding and other tasks, as in #1157. This is useful if there is a bug which causes autograding to halt if there is a problem with one particular student.

There are no tests yet and I haven't used much. I'm not sure if I found the right place to add this. If it is, then let me know and I'll see about adding the tests and documentation.


  • This is the counterpart of the CourseDir.student_id option in that
    it rejects single students, defaulting to them all. Really, first
    student_id is applied, and then student_id_exclude ones are skipped.
  • This is useful if a single student is erroring and needs to be left
    out.

@jhamrick
Copy link
Member

Seems reasonable to me. If you wanted to add a test or two that would be great!

@jhamrick jhamrick added this to the 0.7.0 milestone Aug 21, 2019
@rkdarst rkdarst force-pushed the exclude_student_id branch 2 times, most recently from 6029f4b to 872067f Compare August 24, 2019 12:28
- This is the counterpart of the CourseDir.student_id option in that
  it rejects single students, defaulting to them all.  Really, first
  student_id is applied, and then student_id_exclude ones are skipped.
- This is useful if a single student is erroring and needs to be left
  out.
- autograde, generate_feedback, release_feedback only
@rkdarst
Copy link
Contributor Author

rkdarst commented Aug 24, 2019

Tests added (and found that release_feedback wasn't supported yet, fixed now). Tests are added for autograde, generate_feedback, release_feedback. Anything that goes through the converter system (but perhaps not the exchange system) should work, though, but I think these are the three main ones.

@jhamrick
Copy link
Member

Thanks a lot!

@jhamrick jhamrick merged commit 328e41f into jupyter:master Aug 24, 2019
@jhamrick jhamrick modified the milestones: 0.7.0, 0.6.0 Aug 24, 2019
@rkdarst rkdarst deleted the exclude_student_id branch August 24, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants