Skip to content

Commit

Permalink
Don't skip the assignment if a notebook raises an exception
Browse files Browse the repository at this point in the history
  • Loading branch information
tuncbkose authored and Gehock committed Oct 1, 2024
1 parent dd07b65 commit 5e335b7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion nbgrader/converters/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def _handle_failure(gd: typing.Dict[str, str]) -> None:
self.convert_single_notebook(notebook_filename)

# Exceptions that shouldn't interrupt the entire conversion process should go here
# Those that should go in outer try/except
# Those that should interrupt go in the outer try/except
except UnresponsiveKernelError:
self.log.error(
"While processing assignment %s, the kernel became "
Expand All @@ -405,6 +405,7 @@ def _handle_failure(gd: typing.Dict[str, str]) -> None:
errors.append((gd['assignment_id'], gd['student_id']))
_handle_failure(gd)

# Raise unhandled exceptions for the outer try/except
except Exception as e:
raise e

Expand Down

0 comments on commit 5e335b7

Please sign in to comment.